Comments (8)
If you compile splinepy in debug
mode and run this, you will see that SplineLib
throws the following exception:
ValueError: bsplinelib::parameter_spaces::ParameterSpace::RemoveKnot: Throws the following —> for dimension 0: for dimension0: Cannot insert or remove the first or last knot 2.000000 as only clamped knot vectors are allowed.
from splinepy.
Yes, but IMO, throwing exceptions only in debug mode is like an assertion. Exceptions should also be thrown if the user inputs faulty data. Especially, as we provide wheels that are built in release mode. Just some random segfault should never occur!
from splinepy.
As long as this is the case, the bug remains an issue
from splinepy.
Yes, but IMO, throwing exceptions only in debug mode is like an assertion. Exceptions should also be thrown if the user inputs faulty data. Especially, as we provide wheels that are built in release mode. Just some random segfault should never occur!
This is because #ifndef NDEBUG
is used in the SplineLib
. Do you think we should do our own checks inside splinepy
? However, this would mean that the values are checked twice. Once in splinepy
and once in SplineLib
.
from splinepy.
from splinepy.
from splinepy.
I'll look into that after I'm back from Munich
from splinepy.
Maybe also a good start if knot insertion for C^(-1) is implemented ❤️ @j042
from splinepy.
Related Issues (20)
- Change unittest to pytest
- numpy DeprecationWarning in helpme/fit.py HOT 2
- Inconsistent variables for export function in io module HOT 2
- inplace knot vector update
- Pictures in documentation HOT 1
- Error in example show_microstructures - DoubleLattice
- Issue with Matrix solve HOT 4
- Issues with Proximity HOT 4
- Test Microstructure
- Error in microstructure with normal splinepy install HOT 2
- `boundary_multipatch` seems to be deleting interface information HOT 1
- Bezier Extraction issues HOT 4
- Bezier Extraction matrices for 0th degree spline
- `TileBase` missing `create_tile` interface HOT 1
- inconsistency in fitting HOT 3
- multipatch boundary id magic number HOT 2
- Swept Surface
- revolve with angle=-180
- xml io issues for CATS splines HOT 9
- migration to numpy 2.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from splinepy.