Giter VIP home page Giter VIP logo

Comments (15)

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

Tried multiple combinations

          args: "--config tauri.conf.linux.json"

Moved the file outside and stuff, and it still doesn't take it.

This also leads to Signature not found i believe.

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

What you wrote in your original post should be correct. Can you add something really obvious to the extra config like a weird window config or a beforeBuildCommand that logs something?

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

What you wrote in your original post should be correct. Can you add something really obvious to the extra config like a weird window config or a beforeBuildCommand that logs something?

You mean something that breaks it?

Here's an example of the path being wrong, and the action instantly fails, but when the path is right, it gives the same warning, but doesn't fail

Screenshot 2024-08-03 at 16 32 04 Screenshot 2024-08-03 at 16 31 41

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

You mean something that breaks it?

Pretty much, yeah.

Here's an example of the path being wrong, and the action instantly fails, but when the path is right, it gives the same warning, but doesn't fail

That sounds like it's working correctly then.

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

Also is there a reason why the signature doesn't get created in the action?
Screenshot 2024-08-03 at 16 34 36

Here's the tauri-conf

{
  "$schema": "../node_modules/@tauri-apps/cli/schema.json",
  "build": {
    "beforeBuildCommand": "pnpm build",
    "beforeDevCommand": "pnpm dev",
    "frontendDist": "../dist",
    "devUrl": "http://localhost:2450"
  },
  "bundle": {
    "active": true,
    "category": "Productivity",
    "copyright": "",
    "targets": ["deb", "nsis", "msi", "app", "dmg"],
    "createUpdaterArtifacts": true,
    "externalBin": [],
    "icon": [
      "icons/32x32.png",
      "icons/128x128.png",
      "icons/[email protected]",
      "icons/icon.icns",
      "icons/icon.ico"
    ],
    "windows": {
      "certificateThumbprint": null,
      "digestAlgorithm": "sha256",
      "timestampUrl": ""
    },
    "longDescription": "",
    "macOS": {
      "entitlements": null,
      "exceptionDomain": "",
      "frameworks": [],
      "providerShortName": null,
      "signingIdentity": null
    },
    "resources": [],
    "shortDescription": "",
    "linux": {
      "deb": {
        "depends": []
      }
    }
  },
  "productName": "Octarine",
  "version": "../package.json",
  "identifier": "Octarine",
  "plugins": {
    "updater": {
      "pubkey": "key here",
      "endpoints": [
        "endpoint here",
      ]
    }
  },
  "app": {
    "withGlobalTauri": false,
    "windows": [
      {
        "fullscreen": false,
        "height": 768,
        "resizable": true,
        "title": "",
        "width": 1280,
        "minHeight": 640,
        "minWidth": 480,
        "titleBarStyle": "Overlay",
        "dragDropEnabled": false
      }
    ],
    "security": {
      "assetProtocol": {
        "scope": {
          "allow": ["**"],
          "deny": [],
          "requireLiteralLeadingDot": false
        },
        "enable": true
      },
      "dangerousDisableAssetCspModification": true,
      "csp": "default-src 'self'; img-src 'self' asset: https://* data: blob:; media-src stream: https://* asset: https://*;  style-src 'self' 'unsafe-inline';; connect-src ipc: http://ipc.localhost"
    }
  }
}

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

But it does notarise and create signatures when I run tauri build locally on my mac.

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

Did you set up the updater private key? without it, the tauri cli will not build the updater artifacts (though i'd expect an error since you enabled the updater in tauri.conf.json)

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

Did you set up the updater private key? without it, the tauri cli will not build the updater artifacts (though i'd expect an error since you enabled the updater in tauri.conf.json)

Yep, this is the action!

      - name: Build the app
        uses: tauri-apps/tauri-action@dev

        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_PRIVATE_KEY }}
          TAURI_PRIVATE_KEY: ${{ secrets.TAURI_PRIVATE_KEY }}
          TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_KEY_PASSWORD }}
          TAURI_KEY_PASSWORD: ${{ secrets.TAURI_KEY_PASSWORD }}
        with:
          tagName: ${{ github.ref_name }} # This only works if your workflow triggers on new tags.
          releaseName: "Octarine v__VERSION__" # tauri-action replaces \_\_VERSION\_\_ with the app version.
          releaseBody: "Linux Build"
          releaseDraft: true
          prerelease: false

The duplicates are due to v1 / v2 variable name changes

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

And the same key is in my local zshrc, and it signs the mac build!

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

Ah wait, my bad. You only enabled the .deb build which does not have an updater artifact. On Linux only AppImages are supported.

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

Ah wait, my bad. You only enabled the .deb build which does not have an updater artifact. On Linux only AppImages are supported.

Ah okay. So how does OTA updates work for deb or they won't and AppImage needs to be built out?

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

Yeah, no updates for deb, that's typically handled by something that apt understands (upstream repos or PPAs).

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

Yeah, no updates for deb, that's typically handled by something that apt understands (upstream repos or PPAs).

Understood thanks! So best to go with AppImage if I need to keep the experience the same across Mac / Windows / Linux.

And AppImages can only be built on ARM Linux machines right?

from tauri-action.

FabianLars avatar FabianLars commented on September 7, 2024

And AppImages can only be built on ARM Linux machines right?

Only if your users are on ARM systems. If they are on x86/x86_64 you can build on that instead.

from tauri-action.

rajatkulkarni95 avatar rajatkulkarni95 commented on September 7, 2024

And AppImages can only be built on ARM Linux machines right?

Only if your users are on ARM systems. If they are on x86/x86_64 you can build on that instead.

Weird, I built AppImage using the default action, and couldn't get it to run on x86 systems or ARM systems either. Built on the default Ubuntu 22.04 that the action recommends.

Nevermind, I'll debug. This was helpful.

from tauri-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.