Inline styling for text about react-native-typewriter HOT 8 CLOSED

Thanks for writing up this issue. It should support nesting <Text /> within the component. I'll have to look into why that isn't working. In the meantime, feel free to poke around the code and open a PR if you find a fix!

from react-native-typewriter.

Thanks for writing this up @nsdub. I'm looking into it and will publish a fix once I figure it out.

from react-native-typewriter.

There's currently no special handling for nested Text elements, that's the problem. The TypeWriter component expects children to be a string. I'll need to add an enhancement to handle nested Text correctly.

from react-native-typewriter.

Thanks for the follow up, Taylor!

from react-native-typewriter.

@nsdub I have a fix in progress, should get to complete it and publish a new version sometime this week.

from react-native-typewriter.

@TaylorBriggs Awesome, thanks for taking the time!

from react-native-typewriter.

@nsdub v0.6.0 is published to add support for nested <Text> elements.

from react-native-typewriter.

Thanks for the update here @TaylorBriggs!

I've been playing around with the updated package and I'm noticing that a limitation seems to be that the nested Text tag will work at the conclusion of the string, but not in the middle of a string.

Illustration using the automated test from the last release. This works as expected:

<TypeWriter typing={1} style={{fontSize: 40}}>
  Hello
  {' '}
  <Text style={{ color: 'red' }}>World!</Text>
</TypeWriter>

This does not:

<TypeWriter typing={1} style={{fontSize: 40}}>
  Hello
  {' '}
  <Text style={{ color: 'red' }}>World!</Text>
  This is TypeWriter.
</TypeWriter>

Nor does any combination of throwing 'Hello' or 'This is TypeWriter' into Text tags. From my testing, only the content up to and including the first nested Text tag gets rendered.

from react-native-typewriter.