executeScripts does not work in Firefox about diffhtml HOT 8 CLOSED

Ah, I think I found a workaround. If we clone the original script before we attach the type change, we should be able to reuse that one later vs cloning at the end of the render.

from diffhtml.

https://diffhtml.org/core/version points to 1.0.0-beta.23 now which contains the fix. Please reopen if you find any issues with the new behavior.

Thanks for reporting!

from diffhtml.

Once you confirm the fix and close this issue, I will be looking forward to a new CDN (module) link including this fix.
Like the last time, thank you for the near instant response time!

from diffhtml.

@tbranyen – hopefully this does not introduce regressions with all the subtle <script> variations we have to deal with these days. (type=module; inline vs via src=; defer, async; etc.)

All original props and attributes are mirrored so I think we are covered on that front 👍

from diffhtml.

z = document.createElement('script'); z.textContent = `console.warn(3)`; document.body.append(z);

works in all browsers.

from diffhtml.

Thanks for bringing up this bug, it's a big one. Very strange that Firefox behaves differently than Chrome here.

The reason we clone a new script vs creating with createElement is that when you load the page with a content security policy you won't be able to modify certain scripts after the first page load. Therefore we clone and retain them until they are needed.

It appears Firefox struggles to re-use an existing script once it has been set with a type of no-execute, unlike Chrome.

from diffhtml.

Opened a fix here: #250. I ended up using your advice to createElement and use textContent.

from diffhtml.

@tbranyen – hopefully this does not introduce regressions with all the subtle <script> variations we have to deal with these days. (type=module; inline vs via src=; defer, async; etc.)

from diffhtml.