Comments (8)
Ah, I think I found a workaround. If we clone the original script before we attach the type change, we should be able to reuse that one later vs cloning at the end of the render.
from diffhtml.
https://diffhtml.org/core/version points to 1.0.0-beta.23 now which contains the fix. Please reopen if you find any issues with the new behavior.
Thanks for reporting!
from diffhtml.
Once you confirm the fix and close this issue, I will be looking forward to a new CDN (module
) link including this fix.
Like the last time, thank you for the near instant response time!
from diffhtml.
@tbranyen – hopefully this does not introduce regressions with all the subtle
<script>
variations we have to deal with these days. (type=module
; inline vs viasrc=
;defer
,async
; etc.)
All original props and attributes are mirrored so I think we are covered on that front 👍
from diffhtml.
z = document.createElement('script'); z.textContent = `console.warn(3)`; document.body.append(z);
works in all browsers.
from diffhtml.
Thanks for bringing up this bug, it's a big one. Very strange that Firefox behaves differently than Chrome here.
The reason we clone a new script vs creating with createElement
is that when you load the page with a content security policy you won't be able to modify certain scripts after the first page load. Therefore we clone and retain them until they are needed.
It appears Firefox struggles to re-use an existing script once it has been set with a type
of no-execute
, unlike Chrome.
from diffhtml.
Opened a fix here: #250. I ended up using your advice to createElement
and use textContent
.
from diffhtml.
@tbranyen – hopefully this does not introduce regressions with all the subtle <script>
variations we have to deal with these days. (type=module
; inline vs via src=
; defer
, async
; etc.)
from diffhtml.
Related Issues (20)
- Issues with createState HOT 1
- More tests for babel transform plugin
- DevTools
- React compat layer HOT 1
- Function component: how to use props as slot like custom component? HOT 27
- Components do not mount if missing a return value HOT 1
- delete in removeAttribute causes TypeError HOT 7
- diffhtml/lite: `innerHTML(someNode, "only text")` fails HOT 3
- diffhtml: `process` is not defined HOT 6
- Tracking new HTML parser work HOT 3
- Cannot interpolate string attributes directly HOT 1
- createSideEffect runs on re-render even if already mounted HOT 3
- Parser bug where multiple elements on a single line fails
- Attributes without values breaks the parser HOT 3
- Can't run other packages with core using Deno HOT 2
- setHTML
- diffhtml.org is down HOT 6
- innerHTML fails to diff element when its children have been diffed previously HOT 5
- `window.diff` undefined on old iPad 9.3.5 Safari HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diffhtml.