Giter VIP home page Giter VIP logo

Comments (8)

tbroyer avatar tbroyer commented on August 20, 2024

It's in v0.2 already actually (https://github.com/tbroyer/gradle-nullaway-plugin/blob/v0.2/src/main/kotlin/net/ltgt/gradle/nullaway/NullAwayOptions.kt#L33), though it looks like I forgot to document it in the README.

from gradle-nullaway-plugin.

tbroyer avatar tbroyer commented on August 20, 2024

Fixed in 1babda7

Note that, looking back at the code, I'll soon rename the is-prefixed properties:

  • isAssertsEnabled and isExhaustiveOverride will lose their is prefix in the Groovy DSL (but still have it with the Kotlin DSL)
  • isSuppressSuggestions will be renamed to suppressSuggestions (both Groovy DSL and Kotlin DSL).

So if you use isAssertsEnabled with the Groovy DSL in v0.2, be prepared for a breaking change in the upcoming v0.3.

from gradle-nullaway-plugin.

JakeWharton avatar JakeWharton commented on August 20, 2024

Yep I was super lazy and only checked the README (and am using Groovy so didn't get autocomplete). Thanks!

from gradle-nullaway-plugin.

JakeWharton avatar JakeWharton commented on August 20, 2024

Hmm can't seem to make this work in the Groovy DSL with 0.2 actually. Tried isAssertsEnabled = true, isAssertsEnabled = Boolean.TRUE, isAssertsEnabled.set(true), and assertsEnabled = true. Everything throws unknown property exception.

from gradle-nullaway-plugin.

tbroyer avatar tbroyer commented on August 20, 2024

😭

Will have to add a proper test using the Groovy DSL then, like I did in the errorprone plugin (tbroyer/gradle-errorprone-plugin@39e8350)

from gradle-nullaway-plugin.

tbroyer avatar tbroyer commented on August 20, 2024

With 0.2, that should work with isAssertsEnabled().set(true)

from gradle-nullaway-plugin.

JakeWharton avatar JakeWharton commented on August 20, 2024

Yep, that works. Thanks!

JakeWharton/dagger-reflect#123

from gradle-nullaway-plugin.

tbroyer avatar tbroyer commented on August 20, 2024

Fwiw, I just released v0.3 with the breaking changes.

from gradle-nullaway-plugin.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.