Giter VIP home page Giter VIP logo

Comments (5)

arai-a avatar arai-a commented on May 27, 2024

the bug in SpiderMonkey side: https://bugzilla.mozilla.org/show_bug.cgi?id=1475458

from proposal-binary-ast.

arai-a avatar arai-a commented on May 27, 2024

@syg can I have your opinion, about this issue and https://github.com/binast/ecmascript-binary-ast/issues/51 and https://bugzilla.mozilla.org/show_bug.cgi?id=1475458 ?

from proposal-binary-ast.

syg avatar syg commented on May 27, 2024

@arai-a Sorry for missing this.

Yeah, the current parameter scope is definitely deficient for capturing positional parameters. I had hoped that isSimpleParameterList alone was sufficient -- but as your example points out, having some destructuring without parameter expressions means some arguments need to be accessed by position and some not.

The additional interface for assigning positions to asserted parameter names looks good to me.

from proposal-binary-ast.

arai-a avatar arai-a commented on May 27, 2024

here's WIP patch that adds above interfaces.
https://github.com/arai-a/ecmascript-binary-ast/tree/spec-draft-positional-formal
I'll open PR once rest parameter issue turns out to be solvable on SpiderMonkey side

from proposal-binary-ast.

arai-a avatar arai-a commented on May 27, 2024

I think we can workaround the rest parameter issue for now by a cheat (https://bugzilla.mozilla.org/show_bug.cgi?id=1475458#c9) as long as we know which is simple rest parameter.
the change in https://github.com/binast/ecmascript-binary-ast/pull/52 should help anyway.

from proposal-binary-ast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.