Giter VIP home page Giter VIP logo

Comments (6)

TcT2k avatar TcT2k commented on July 18, 2024

Which platform you are building on?

I'll probably look into newer version, but in the mean time you could give it a try with pdfium revision 2118.

from wxpdfview.

trogmaniac avatar trogmaniac commented on July 18, 2024

Sorry for not mentioning that, i'm under Windows. It took me two days to build pdfium because their build instructions are so horribly wrong. I don't think i want to go through that again.

I'd rather try to adjust wxPDFView :)

from wxpdfview.

TcT2k avatar TcT2k commented on July 18, 2024

Yeah building pdfium is not that easy (and it was even harder).

If you get it build with the recent pdfium any PR is welcome. I can't promise when I'll be able to look into it, but I'm definitely interested.

from wxpdfview.

trogmaniac avatar trogmaniac commented on July 18, 2024

I think i got it to work. Most changes except two were straight forward. I'm not sure about the two code locations with the (CPDF_Action *) casts. You should check those.

Here are two diff files, one for the code, the other one for FindPDFium.cmake. I'm sure there are more elegant ways to do this, but i'm a GIT noob.

http://pastebin.com/n2S81g8C
http://pastebin.com/sDk2yFRt

And BTW: Thanks for wxPDFView, this is great stuff and will be very useful.

from wxpdfview.

TcT2k avatar TcT2k commented on July 18, 2024

Thank you very much for the patches. Looks good to me. I've applied them.

Diffs from pastebin are easy enough to merge, but have a look at https://help.github.com/articles/using-pull-requests/ how to create a pull request. If you have done it once it's pretty easy and makes it even easier for the author to merge the changes.

from wxpdfview.

trogmaniac avatar trogmaniac commented on July 18, 2024

Thanks, i'll look into that.

Some additional information i forgot:
a) I was using VS2013, but 32bit builds only. I hope the changes still work on other platforms/compiler.

b) I could't find what the current pdfium version number is, so i just wrote "latest version".

from wxpdfview.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.