Incorrect MIN Python Version in README about stumpy HOT 11 OPEN

Hmm, that's a good point. It's probably a good idea to update it. To some extent, STUMPY technically still supports Python 3.7 but only for older STUMPY versions. However, this is confusing and it is better to be consistent and update everything to 3.8.

We should add "f) README.md" to the comments of the pypi.sh file of "things-to-do":

Because STUMPY has not tested the support for python 3.12 yet in .github/workflows/github-actions.yml

Indeed. I have added #958 (and corresponding STUMPY v1.12.1/v.1.13 Milestone) to track this.

from stumpy.

@joehiggi1758 Thank you for your interest in contributing to STUMPY. Yes, please feel free to take this one! It looks like we need:

1. Update the Python version listed in the README.md file
2. Add a note to the pypi.sh file for things to update/change when we upload a new version to PyPI
3. Check if we have 3.7 hardcoded anywhere else in our docs/tutorials?

Please do not hesitate to ask any questions and take a look at our Contributors Guide for a good place to start (that document might need some love too as it might be outdated).

from stumpy.

Hey All - hope you're having a wonderful day!

Would it be alright if I take this one? I'm new to OSS contributions, but want to help!

from stumpy.

@seanlaw thanks so much for the opportunity to help, I'm on it!

1. Done!
2. Can you expand a bit here?
3. Currently working on!

Will try to knock this one out by end of week!

from stumpy.

Can you expand a bit here?

So, the pypi.sh file is a simple helper script that we use to help us upload the latest package version to PyPI. Since this uploading task is only performed once in a while, we also store "last minute steps" (as comments) in this file to remind us of the additional things that we need to check off our list BEFORE we upload to PyPI. In this particular case, we should add f) README.md to the comments of the pypi.sh file of "things-to-do":

# 5. Bump minimum versions and dependencies
#    a) setup.py
#    b) requirements.txt
#    c) environment.yml
#    d) .github/worflows/github-actions.yml
#    e) recipes/meta.yaml in conda-feedstock
#    f) README.md
# 6. Commit all above changes as the latest version number and push

Currently, the list ends at 5. e) but we should add a 5. f) as shown above so that we are reminded to update the information. Let me know if that makes sense or please seek further clarification.

Actually, I just realized that we no longer have a setup.py file (since we migrated over to using a pyproject.toml file instead for building our package). So, would you mind replacing the above with:

# 5. Bump minimum versions and dependencies
#    a) pyproject.toml
#    b) requirements.txt
#    c) environment.yml
#    d) .github/worflows/github-actions.yml
#    e) recipes/meta.yaml in conda-feedstock
#    f) README.md

from stumpy.

@joehiggi1758 Once this is done then somebody can work on issue #973, which is somewhat related to this

from stumpy.