ValidationError not instanceof Error about jsonschema HOT 4 CLOSED

Ah ok. That might be a good excuse to inherit from Error.

Or, create a separate type of object for the error itself, and it contains a ValidationError instance.

I'll take a look.

from jsonschema.

A ValidationError isn't an object that's thrown, it just contains details about a particular problem with your instance. There could be several of them all at once, they're all returned in a ValidatorResult object.

I suppose one might find a reason to throw a ValidationError, is that what you want to do?

Does that answer your question?

from jsonschema.

Oh I see! Thanks for answering so quickly.

The ValidationError is added to the ValidatorResult but if the option {throwError: true} is set, the first
ValidationError is thrown but not as an Error Object. Would it be worth it to add an option to the constructor to initialize it as an object?

var ValidationError = exports.ValidationError = function ValidationError (message, instance, schema, propertyPath, options) {
...
  if (options && options.throwError) {
    Error.call(this, message);
    Error.captureStackTrace(this, ValidationError);
  }
}
...

I'm asking mainly because using promise/deferred methods usually catch instanceof Error. I think I have a custom solution but I thought it would be cool to reach out to you.

I guess that would require prototype to be Error which might do bad things. I shall fork and see.

from jsonschema.

I'm going to close this as a duplicate of #264, which should solve this issue. Please drop a comment if there's anything missing in that issue.

from jsonschema.