Giter VIP home page Giter VIP logo

Comments (3)

tdurieux avatar tdurieux commented on September 26, 2024 1

I added a warning message when a regex character is detected.
image

from anonymous_github.

tdurieux avatar tdurieux commented on September 26, 2024

It was on purpose that the terms are interpreted as regex.
I would like to keep it that way.

I think a better option would be to add a warning when a regex character is detected in the terms field.

WDYT?

from anonymous_github.

Maximvdw avatar Maximvdw commented on September 26, 2024

So I have two sides for this answer:

  1. For some reason my mind did not see that I could actually use regexp and shorten the list that I currently have by quite a bit.
    So in that way, it seems like its best to keep the current functionality. However, it was not clear to me that this was even possible.

  2. I can imagine that regular expressions is not for everyone, especially if you are using github for datasets, etc.... In which case some people might struggle to anonymise their repo because they are unintentionally using regular expressions.

So for now, I would say to keep it - but maybe in the future when there is time, it would be a good idea to maybe have a checkbox under "advanced options" to interpret the terms as regular expressions or not (I would default set it to "not" on new repositories if you ever implement this).

from anonymous_github.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.