Giter VIP home page Giter VIP logo

Comments (8)

VishalNehra avatar VishalNehra commented on July 28, 2024

Force Chooser dialog comes once you choose "Other" from the Open with dialog.
The open with dialog just makes it easy for you by not going through the long list of all apps. Otherwise you can always choose to open according to your own using other option

from amazefilemanager.

lbdroid avatar lbdroid commented on July 28, 2024

You aren't understanding.
The issue is that the open with dialog does not show once you have selected an item and flagged it to always use that handler.

Edit: The expected behavior is that when you "just click" on a file, it will launch the handler that it is set to "always use", and when you select "open with", it would force chooser.

Right now you aren't using proper intents/intent filters to launch the integrated file handlers (text file, zip file, etc.), which means that by default, it will try to use the integrated file handlers, and that open with gives a roundabout way to bypass that. If you bring it back one step so that your integrated handlers respond the same way as other user-installed file handlers, then you achieve the expected behavior.

from amazefilemanager.

arpitkh96 avatar arpitkh96 commented on July 28, 2024

Your issue is expected to be solved with latest commit. At least for text files. Zip files will still be preferred to be opened directly in app only. Still you can use "open with " for them

from amazefilemanager.

lbdroid avatar lbdroid commented on July 28, 2024

Ok.

I see the switch to openunknown. I don't see a change to long-press-->open-with using force-chooser.

What is the rationale for keeping zip files handled internally? Presumably, if the user has installed an alternative zip file handler, they would have installed it because they prefer to use it.

from amazefilemanager.

lbdroid avatar lbdroid commented on July 28, 2024

Here, I think this should do it; lbdroid/AmazeFileManager@485de2c

Note: I have NOT created a pull request, because I am not in a position right now to compile/test it.

from amazefilemanager.

arpitkh96 avatar arpitkh96 commented on July 28, 2024

Zip viewing was preserved so the animations work fine. I don't know why but fragment transitions don't animate in new activity. I will look into that commit

from amazefilemanager.

lbdroid avatar lbdroid commented on July 28, 2024

You should be able to use Intent.resolveActivity(PackageManager) or PackageManager.resolveActivity(Intent, MATCH_DEFAULT_ONLY) to detect if we are the default handler, and then transition the fragment directly.

from amazefilemanager.

lbdroid avatar lbdroid commented on July 28, 2024

I've been able to test that commit now, and it works exactly as expected, so I have created a pull request. When you click on a file, it will launch the default handler, or show chooser if there is no set default. When you long-click --> menu --> open with, it ALWAYS forces the chooser.

from amazefilemanager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.