Comments (5)
From @jayjun on February 2, 2017 10:50
#388 implies that config variables are available during Docker builds, but that's certainly untrue. However, naively passing all config variables to --build-args
probably isn't wise.
Docker discourages,
using build-time variables for passing secrets like github keys, user credentials etc.
So I'm wondering how we can pass secrets to Docker builds as well. I have an actual need for this, related to integrating Google Cloud SQL.
from builder.
From @bacongobbler on February 2, 2017 15:22
@jayjun I think you're talking about something else different. This issue is talking about passing in build args when we build the component itself, not the app. Apps are certainly passed in envvars during the build.
from builder.
From @bacongobbler on February 2, 2017 15:24
See https://github.com/deis/builder/blob/master/pkg/gitreceive/build.go#L98-L102.
from builder.
From @jayjun on February 2, 2017 16:45
@bacongobbler Yes, config variables are mapped to the build pod's env variables.
But running docker build
doesn't automatically inject the surrounding pod's env variables into the app container that it's building (unlike buildpack shell scripts).
In fact, there's no way to add build-time environment variables until ARG was introduced.
from builder.
From @bacongobbler on February 2, 2017 16:56
So, to clarify your request, you would like to have environment variables injected into the build environment when you are performing a git push
with an app that uses a Dockerfile. Is that correct? I was unaware that we didn't already do that. That can easily be rectified. For reference we already do this for apps that rely on buildpacks.
If it is, can you open another ticket for that? That request is separate than what is requested here.
from builder.
Related Issues (20)
- s2i (source2image) builder HOT 1
- builder should also support password callback HOT 1
- Make docker socket path configurable
- Add package level godoc
- Proposal: send logs directly from builder pods back to builder pod HOT 5
- Run as non-root user HOT 7
- Allow git pushes to respond with an informative failure message
- Have probes ping the SSH server HOT 1
- Use a cheaper way to ping the Kubernetes API in the health check endpoint HOT 2
- sign tarballs and compiled slugs HOT 1
- [META] Future runner capabilities HOT 3
- [META] Future build pipeline
- List of issues with running 2 or more builder pods in a cluster
- Allow namespacing of private registry images
- Add CURL variables to slugbuilder appConfig k8s_util
- Release phase HOT 1
- [ERROR] Failed handshake: read tcp ...
- Pushing any app without env variables fails HOT 2
- Add a test for #49 - BUILDPACK_URL
- Builder fails to resolve host HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from builder.