Comments (4)
The presence of the AWS_ vars on the running environment prompts dockerbuilder to use them instead of using the ones configured when installed. The impact is that dockerbuilder will potentially attempt to store the resulting artifacts on a different AWS account than the one configured at installation time.
Our research found two ways of addressing this:
a) Modify dockerbuilder so that it sanitizes the relevant env vars before pushing to S3 the resulting artifact, by inserting a step before downloading the tar file
b) Modify object-storage-cli to have it ignore AWS related variables on the environment.
Having said all of that, these fixes/approaches do not consider this case: when the user intentionally wants to override the default credentials and 'force' dockerbuilder to push the artifact to a different AWS account. If any member of the community is using this scenario then we won't be able to submit the fix, and will just share it as a snippet.
from dockerbuilder.
I can't imagine a scenario myself where it's considered correct behavior for the builder to change its push target for artifacts based on the application's configuration, and I'd have to see an example of how it could be used productively to even consider that as intentional. I am for fixing the bug, so apps with AWS_S3 storage buckets of their own to attach can do so using environment variables and not interfere with Builder or its work. 👍
from dockerbuilder.
PR #14 merged! Thank you for the contribution @eudalov and @dvalfre
from dockerbuilder.
This is quite a serious bug. I'm surprised I have not run into it more often. Maybe because a lot of the apps we deployed on hephy were dockerized containers.
from dockerbuilder.
Related Issues (9)
- Support for multi-stage builds in dockerbuilder
- Outdated binary for object-store-cli HOT 1
- Do not inject ARG on newer Docker versions. HOT 2
- Support of cache_from attribute
- pre/post compile hooks HOT 9
- Add information to the README on how to configure dockerbuilder for standalone use HOT 1
- implement dockerbuilder tests
- implement everything in Go HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dockerbuilder.