Giter VIP home page Giter VIP logo

Comments (5)

AndyRusso avatar AndyRusso commented on September 1, 2024 1

I agree with OP. I have lost my position in videos when pressing home key while being deep into reading comments to go back up - it's not intuitive to capture home and end keys at all times in my opinion.

from piped.

Bnyro avatar Bnyro commented on September 1, 2024

Imo it's reasonable enough to capture home and end keys, that's been added with #3664 and should be the expected behavior.

from piped.

opusforlife2 avatar opusforlife2 commented on September 1, 2024

That PR has no description or sample video so I can't tell how it uses these keys.

Anyway, I think the main idea here is that when the focus is with the player, it's expected that certain keys will have overrides to act as shortcuts for various player functions.

However, when the player loses focus, the keys should go back to performing functions expected of them for the rest of the webpage.

from piped.

ac615223s5 avatar ac615223s5 commented on September 1, 2024

I added it because it is the behaviour on youtube but I don't mind either way. Also, it's related to #3136.

from piped.

opusforlife2 avatar opusforlife2 commented on September 1, 2024

I vaguely remember back when I used Youtube that it had pretty wacky behaviour. This might have been one of those things.

from piped.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.