Comments (5)
I agree with OP. I have lost my position in videos when pressing home key while being deep into reading comments to go back up - it's not intuitive to capture home and end keys at all times in my opinion.
from piped.
Imo it's reasonable enough to capture home and end keys, that's been added with #3664 and should be the expected behavior.
from piped.
That PR has no description or sample video so I can't tell how it uses these keys.
Anyway, I think the main idea here is that when the focus is with the player, it's expected that certain keys will have overrides to act as shortcuts for various player functions.
However, when the player loses focus, the keys should go back to performing functions expected of them for the rest of the webpage.
from piped.
I added it because it is the behaviour on youtube but I don't mind either way. Also, it's related to #3136.
from piped.
I vaguely remember back when I used Youtube that it had pretty wacky behaviour. This might have been one of those things.
from piped.
Related Issues (20)
- add framerate for video quality sector too
- 1080p not working HOT 5
- Videos sometimes load but do not actualy play HOT 4
- Videos with chapters on Smart TV (LG) do not have a player
- Add playsinline attribute to <video> tag in VideoPlayer.vue
- Videos don't play on Chromium HOT 8
- java.lang.Exception: error sending request for url
- Hide channels feature HOT 2
- Невозможно зарегистрироваться
- Views, Upload Time text is barely legible HOT 1
- 720p 30fps not available on 60fps videos anymore
- unaable to play video on any of piped intasces HOT 1
- Got error: "Sign in to confirm that you're not a bot" HOT 4
- Unable to add any videos [to playlist], since they were unable to be fetched HOT 1
- Allow running in HTTP (without https)
- improve playlist display aside
- Many of the Piped instance listed are no longer active with some being entirely different sites
- Why Piped doesn't fetch feed correctly? HOT 2
- Imported playlists have no name
- nvm
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from piped.