Comments (7)
leMaik
commented on May 10, 2024
2
Updated all three versions and also added checks so this doesn't happen again.
from mdi-material-ui.
duongdev
commented on May 10, 2024
1
I think this bug happens because the new @mdi/[email protected] has both textbox and text-box icons which are expected to be TextBox and Textbox in mdi-material-ui. The generate-module.js generates both TextBox.js and Textbox.js files that could make the compiler confused.
from mdi-material-ui.
leMaik
commented on May 10, 2024
1
@duongdev That would break all imports for people who don't use tree shaking to import from the index.js 😬
from mdi-material-ui.
leMaik
commented on May 10, 2024
@duongdev Thanks for finding out what's wrong here! 👏 Should we add a special case and name that single file Text-box.js but still export it as TextBox from index.js?
from mdi-material-ui.
duongdev
commented on May 10, 2024
@leMaik yeah, I think that solution is OK. Or we just keep all js files name the same as the icons' name from materialdesignicon.com (kebab-cased) to prevent similar issues later?
from mdi-material-ui.
xs9627
commented on May 10, 2024
Got the same error. Hope it could been fixed soon. Thanks.
from mdi-material-ui.
duongdev
commented on May 10, 2024
@leMaik ahh I see, so I think your solution is the best for now 👍
from mdi-material-ui.
Related Issues (20)
- I am using "mdi-material-ui": "^6.10.0" version and cannot find cube-off mdi icon there although HOT 6
- Your site is unusable HOT 1
- Image is not a constructor HOT 3
- Project Website is Down HOT 1
- CamelCase generator issue HOT 2
- TrayArrowDown is missing? HOT 3
- material-ui dependence HOT 4
- License Issue HOT 4
- TruckSnowflake icon is not exported HOT 1
- WizardHat is not exported HOT 2
- Re-release with @mdi/js version v6.6.96 HOT 5
- Unable to upgrade to React v18.0 HOT 1
- MedicationOutline is not exported HOT 1
- All icons rerender without any change HOT 2
- Update Request (for newer icons) HOT 1
- More efficient imports HOT 6
- Update to MDI v7.2.96 HOT 2
- @mui/joy HOT 1
- support for MDI v 7.x HOT 1
- Update to MDI v7.4.47 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdi-material-ui.