Comments (6)
TeamWicket
commented on July 24, 2024
@thanonchai let me know if you want to pick this up :)
It should be fairly easy either way you'd like to implement one or two tests (unit or integration). Let me know if you need help
from twilio-bcp-calltree.
drobiu
commented on July 24, 2024
I have created some tests (#94) but I think there's still plenty more for @thanonchai to test
from twilio-bcp-calltree.
TeamWicket
commented on July 24, 2024
Sure, I don't mind having unit tests as well. Thanks for your contribution @drobiu
from twilio-bcp-calltree.
nwnt
commented on July 24, 2024
Hi there, sorry was busy for the past few days. I added 4 more test cases for this service, all of them are integration tests. I plan to add more for the save methods.
Definitely you can assign the issue to me :)
from twilio-bcp-calltree.
nwnt
commented on July 24, 2024
Just incorporated another commit. Thinking this should be ready to be reviewed and merged. Let me know if your comments :).
BTW I'm kinda assuming a bit on the null cases which seemed to be correct when I ran them. Not sure if they're intended to behave like that.
from twilio-bcp-calltree.
nwnt
commented on July 24, 2024
... just noticed that I missed fetchManycontactsById. Added one for it.
from twilio-bcp-calltree.
Related Issues (20)
- Test card
- Business Domain Diagram
- Create repositories for each microservice HOT 1
- Create UI Repo and move all UI code to this repo
- Create BOM
- Create Contact MS
- New high level stats dto for dashboard
- High level stats endpoint / service HOT 1
- Soft delete for Twilio numbers
- Event stats page (UI)
- Wizard to create events HOT 3
- Scheduled events
- Securing application
- Rebrand the terminology in the app
- Recipient is hardcoded to have a sender phone number HOT 1
- Adding Unit test coverage to the Java/Kotlin code HOT 3
- Add Frontend unit test coverage HOT 7
- General Improvements
- Fund dependencies
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twilio-bcp-calltree.