Giter VIP home page Giter VIP logo

Comments (9)

Nielsbishere avatar Nielsbishere commented on July 22, 2024
// Make sure we free the data objects we allocated.
for (auto& data : m_data)
{
	delete data;
}

In frame_graph.hpp Destroy function
Auto doesn't provide clarity about the type; but the type is void*. This means that it doesn't call free or the destructor of the object.

Memory impact

Among the largest left over objects are because of this issue (est. 20%)

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024

PhysicsEngine::destroy is never being called, leaving behind bullet's resources.

Memory impact

The biggest impact as bullet allocates several memory pools (est. 60%)

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024

texture_pool ptr is potentially never reset; leaving behind some memory.

Memory impact

Not that much (est. 5%)

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024
  • aiScene* isn't being cleaned up
  • Viknell probably still has materials left over
  • Sponza probably still has materials left over

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024
  • Models don't clean up their allocated materials
  • Physics component doesn't clean up the rigid bodies, shapes, etc.

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024
  • Thread pool enqueue leaks memory

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024
  • Build acceleration structure task doesn't clean up the CB

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024

Possible issues to look into further:
Left-over data includes; C++ initialization data which should be taken care of by the program finishing unloading. Other than that; file streams seem to have temporary memory that may or may not be deleted after program end.

from wisprenderer.

Nielsbishere avatar Nielsbishere commented on July 22, 2024

Even though CPU memory leaks are mostly cleaned up, there could potentially still be GPU memory leaks.

from wisprenderer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.