Giter VIP home page Giter VIP logo

Comments (6)

cnuernber avatar cnuernber commented on June 25, 2024 1

The fix is really two-fold. First, select-rows should clear specifically print-index-range. Second, printing itself should never cause that exception so it needs to always filter print-index-range to be in the range of the current dataset row indexes.

One thing you may really like - select-rows now accepts negative indexes which will index from the end python-style.

from tech.ml.dataset.

alex314159 avatar alex314159 commented on June 25, 2024

And maybe a better example of the issue:

(def x (ds/->dataset {:a (range 1000) :b (range 1000)}))
=> #'jasmine.var/x
(ds/select-rows (ds/tail x 5) [0 1])
Error printing return value (IndexOutOfBoundsException) at ham_fisted.ChunkedList/sublistCheck (ChunkedList.java:216).
End index out of range: end-index(5), n-elems(2)

from tech.ml.dataset.

cnuernber avatar cnuernber commented on June 25, 2024

That is the error I get - index out of bounds - it was because the head/tail operations put print-index-range metadata on the returned dataset and the select-rows operation didn't clear the metadata (which in general it should not). So when you go to print the third, 2 row dataset it has print-index-range of (range 5) from the head operation :-).

from tech.ml.dataset.

cnuernber avatar cnuernber commented on June 25, 2024

New release is up :-)

from tech.ml.dataset.

alex314159 avatar alex314159 commented on June 25, 2024

thanks!!

from tech.ml.dataset.

harold avatar harold commented on June 25, 2024

Wow! Nice!

from tech.ml.dataset.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.