Giter VIP home page Giter VIP logo

Comments (2)

ryanto avatar ryanto commented on July 29, 2024

Makes sense.

find_best is really used to find the best build based on your params (master/branch/sha smoke test/whatever). It's not really used for promotion/rollback purposes.

I didn't consider the UI/sync issues with maintaining best_id (since its not really an updatable thing). Sounds like a pain.

👍 For having the front end have its own logic, and yes it's just master+active+latest created_at.

from front_end_builds.

samselikoff avatar samselikoff commented on July 29, 2024

Ok great so we need

  • to remove best_build_id from an app's serialized json in the backend and
  • to add the logic to the frontend

from front_end_builds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.