Comments (7)
I had a similar issue where this check would fail if I had an ssh session open, here's the example output from w -hs
:
erikn tty1 :0 33:37 lxqt-session
erikn pts/0 192.168.1.104 1.00s w -sh
erikn pts/1 192.168.1.104 28:53 less /home/erikn/.config/autostart/kodi.desktop
from teeedubb-xbmc-repo.
Is there a specific reason to set (and therefore potentially overwrite) the DISPLAY variable?
Maybe it would be appropriate to only set it when its not already set to a non empty value?
from teeedubb-xbmc-repo.
Hi,
Is there a specific reason to set (and therefore potentially overwrite) the DISPLAY variable?
Maybe it would be appropriate to only set it when its not already set to a non empty value?
I agree -- yesterday (before stumbling over this issue report ;) I removed the whole DP=$(w -hs | awk '{print $3}') && export DISPLAY=$DP
part from both ~/.kodi/addons/script.steam.launcher/resources/main.py
and ~/.kodi/addons/script.steam.launcher/resources/scripts/steam-launch.sh
(or its copy in ~/.kodi/userdata/addon_data/script.steam.launcher/scripts/steam-launch.sh
, respectively) and -- tadaa! -- the steam launcher did work again! I reckon explicitly setting DISPLAY should rarely, if ever, be necessary since if the launcher gets launched from Kodi it should already be running in an X environment.
(BTW, changing the steam-launcher.sh script was necessary since otherwise the steam executable itself would complain about not being able to open the -- incorrectly set -- display.)
Here's what w -hs
gave me when calling it from an xterm running in the same display as Kodi:
mythtv tty1 - 39.00s xterm
mythtv pts/0 2003:dd:f25:2d00 8:31 -bash
mythtv pts/1 :0 7.00s w -hs
In this case, even FlyingRedBull's head -n 1
wouldn't be of any help...
Cheers --
Torsten
from teeedubb-xbmc-repo.
Thanks for reporting this and providiing feedback. This all came about because two fresh ubuntu 18.10 installs default to using :1 as the DISPLAY, and the script wouldnt run. I cant remeber why I originally set the DISPLAY variable in the script, but removing it allows it to launch on my machine too.
I'll update the script in the repo. Thanks
from teeedubb-xbmc-repo.
OK, should be all fixed in the latest version.
from teeedubb-xbmc-repo.
I have encountered a similar problem on Manjaro KDE where the default.py script queries for windows. The output of w -hs
does not contain the DISPLAY
, which makes wmctrl -l
fail because DISPLAY is incorrectly set. The script fails with an error message at that point and Steam will start. I have fixed this issue on my system by replacing $DP
with :0
, but that's not a very portable solution.
from teeedubb-xbmc-repo.
Hi,
Sorry about the late reply.
I am going to target and test against the Linux OS recommended by Steam, which currently is Ubuntu LTS. One of Linux's strength is also its weakness and I dont have the time or resources to test against all distros out there and the addon allows for customisation of scripts to suit each system.
Though in saying that, I am more than happy to merge a better solution which allows for greater compatibility amongst distros.
from teeedubb-xbmc-repo.
Related Issues (20)
- Script fails due to syntax error. HOT 11
- Make SteamLauncher work when Kodi is in standalone HOT 2
- Unable to start steam / check error logs HOT 18
- Steam Launcher doesn't recognize Gnome as a window manager HOT 8
- Steam opens new friends list window on launch HOT 2
- Another spawned instance of kodi when exiting steam HOT 3
- "Play" doesnt work HOT 2
- Steam Launcher doesn't work with python3 HOT 4
- Steam launcher doesn't recognise my path HOT 1
- steam-launcher still complains about python-2.7.19 not found HOT 9
- Steam Launcher fails on Kodi Matrix Beta 2 HOT 2
- Error: module 'xbmc' has no attribute 'translatePath' HOT 4
- bagelradio HOT 1
- steam-launcher uses wrong locale HOT 1
- steam.launcher: Not fully functional with new Steam changes HOT 5
- Teeedubb repo not working for Kodi v20 HOT 2
- Steam Launcher sleeper script fails to recognise Steam closure after a recent Steam update (probably) HOT 6
- Error when using steam launcher on NixOS: `which` not found HOT 3
- Doesn't Work with Minimize Big Picture HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teeedubb-xbmc-repo.