Comments (7)
There are no special dimensions, we have just added special operand which enforces same minor version.
One would expect following, right?
>>> fmf.context.Context(distro='fedora-33').matches('distro == fedora')
True
I guess we will not break anything if in comparison we require both sides to have non-empty version parts so
foo > foo-1
as well as foo > bar
is CannotDecide
but foo-1 > foo-0.8
from fmf.
How about foo >= foo-1
? Since foo == foo-1
is True we need to have foo >= foo-1
True as well, IMHO
from fmf.
What about requiring context (left side) to have version defined if rule (right side) uses it?
context operator rule | result |
---|---|
fedora-33 == fedora | True |
fedora-33 >= fedora-32 | True |
fedora == fedora | True |
fedora >= centos | True (string comparison) |
fedora == fedora-33 | CannotDecide |
fedora >= fedora-33 | CannotDecide |
from fmf.
I think I need to adjust how comparing works (again) - in addition to have version part filled, ContextValue will need to have same name parts.
Because now you can't really compare module streams.
This matches because of string compare between module names
>>> Context("module = py:5.28").matches("module > perl:5.28")
True
If you use minor mode comparison it is skips compare as one expect but you loose ability to version compare streams between major (here perl:6 to perl:5) which you are likely to need...
>>> Context("module = py:5.28").matches("module ~> perl:5.28")
CannotDecide:
>>> Context("module = perl:6.28").matches("module ~> perl:5.28")
CannotDecide:
So the proposal is to allow comparing only if both sides have same name, so following will be possible
>>> Context("module = perl:6.28").matches("module > perl:5.28")
True
>>> Context("module = py:5").matches("module > perl:5.28")
CannotDecide:
>>> Context("module = py:5").matches("module >= perl:5.28")
CannotDecide:
from fmf.
From IRC:
rhel-7 == rhel-7.3 == rhel-7.3.eus
thus rhel-7 >= rhel-7.3 >= rhel-7.3.eus
But if you need strict check for minor version you need to use <, ~<, >, ~>
e.g.
rhel-7 > rhel-7.3 ---> CannotDecide
from fmf.
I would argue against
fedora >= centos | True (string comparison)
I reckon there is no way to tell which one actually is higher / newer / whatever. Comparing different distros does not make much sense. The resolution in this case should be: CannotDecide
from fmf.
fedora >= centos | True (string comparison)
I reckon, there is no way to tell which one actually is higher / newer / whatever. Comparing different distros does not make much sence. The resolution in this case should be: CannotDecide
Yes, it will be CannotDecide
from fmf.
Related Issues (20)
- Replace jsonschema.RefResolver as is being deprecated HOT 2
- RFE: Support for merging phase metadata when multiple phases are used HOT 1
- Api documentation
- `.fmf/config` allow to redefine tree root relatively
- `.fmf/config` define type/flavor of an fmf tree
- Python improvements
- More `dict` and `Path` like api
- New project `fmf-jinja`
- Migrate `tmt.utils.field` and `tmt.utils.DataContainer` to `fmf` HOT 4
- Rewriting `fmf.Tree`
- Add callback to all methods changing node data HOT 2
- Keeping the 'node' as an object even though it has children and is not a leaf HOT 1
- Support additions to context made by adjust rules for follow-up rules HOT 1
- Missing `sdist` in PyPI HOT 2
- Add operator for REGEX matching in context HOT 1
- `context` should always populate `path` HOT 2
- Support inheritance when parent is a list and child is not a list HOT 19
- Directive: `mark-non-leaf`
- Inconsistent order of operations HOT 6
- Merge ignored for node without parent
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fmf.