Giter VIP home page Giter VIP logo

Comments (7)

lukaszachy avatar lukaszachy commented on August 16, 2024

There are no special dimensions, we have just added special operand which enforces same minor version.

One would expect following, right?

>>> fmf.context.Context(distro='fedora-33').matches('distro == fedora')
True

I guess we will not break anything if in comparison we require both sides to have non-empty version parts so
foo > foo-1 as well as foo > bar is CannotDecide but foo-1 > foo-0.8

from fmf.

lukaszachy avatar lukaszachy commented on August 16, 2024

How about foo >= foo-1 ? Since foo == foo-1 is True we need to have foo >= foo-1 True as well, IMHO

from fmf.

psss avatar psss commented on August 16, 2024

What about requiring context (left side) to have version defined if rule (right side) uses it?

context operator rule result
fedora-33 == fedora True
fedora-33 >= fedora-32 True
fedora == fedora True
fedora >= centos True (string comparison)
fedora == fedora-33 CannotDecide
fedora >= fedora-33 CannotDecide

from fmf.

lukaszachy avatar lukaszachy commented on August 16, 2024

I think I need to adjust how comparing works (again) - in addition to have version part filled, ContextValue will need to have same name parts.

Because now you can't really compare module streams.
This matches because of string compare between module names

>>> Context("module = py:5.28").matches("module > perl:5.28")                                                                                      
True

If you use minor mode comparison it is skips compare as one expect but you loose ability to version compare streams between major (here perl:6 to perl:5) which you are likely to need...

>>> Context("module = py:5.28").matches("module ~> perl:5.28")                                                                                      
CannotDecide:
>>> Context("module = perl:6.28").matches("module ~> perl:5.28")
CannotDecide:

So the proposal is to allow comparing only if both sides have same name, so following will be possible

>>> Context("module = perl:6.28").matches("module > perl:5.28")
True
>>> Context("module = py:5").matches("module > perl:5.28")
CannotDecide:
>>> Context("module = py:5").matches("module >= perl:5.28")
CannotDecide:

from fmf.

lukaszachy avatar lukaszachy commented on August 16, 2024

From IRC:
rhel-7 == rhel-7.3 == rhel-7.3.eus thus rhel-7 >= rhel-7.3 >= rhel-7.3.eus
But if you need strict check for minor version you need to use <, ~<, >, ~> e.g.
rhel-7 > rhel-7.3 ---> CannotDecide

from fmf.

martinky82 avatar martinky82 commented on August 16, 2024

I would argue against

fedora >= centos | True (string comparison)

I reckon there is no way to tell which one actually is higher / newer / whatever. Comparing different distros does not make much sense. The resolution in this case should be: CannotDecide

from fmf.

lukaszachy avatar lukaszachy commented on August 16, 2024

fedora >= centos | True (string comparison)
I reckon, there is no way to tell which one actually is higher / newer / whatever. Comparing different distros does not make much sence. The resolution in this case should be: CannotDecide

Yes, it will be CannotDecide

from fmf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.