When using HMR with TipTap, throws error on module reload. about prosemirror-dev-toolkit HOT 5 CLOSED

I'm also using React 18 so maybe there is some weird complication with the double useEffect in dev that they've added.

from prosemirror-dev-toolkit.

Hey @hitsthings thanks for the bug report! Yeah probably something like that is happening, it's not entirely bullet-proof hack. Any chance you can link a reproduction where the bug occurs? Like a TipTap example with dev-toolkit added? I want to add a test case for it if possible so I won't accidentally break it down the road.

from prosemirror-dev-toolkit.

https://github.com/hitsthings/prosemirror-dev-toolkit-tiptap-test shows it.

Commands I ran to set it up:

npx [email protected] prosemirror-dev-toolkit-tiptap-test --template tiptap
npm install prosemirror-dev-toolkit npm start

Then I edited Tiptap.jsx to add an "s" after "World". This worked fine.

Then I ran applyDevTools() in a useEffect in the TipTap component. This worked fine.

Then I removed the "s" from "Worlds". This caused a console error similar to the reported one and the message no longer printed in the browser.

Every other edit thereafter had a similar error.

Hope that helps! I dunno how you would test HMR stuff. 😬
Thanks for the toolkit!

from prosemirror-dev-toolkit.

Thanks, that helped a lot! Should be fixed in 1.0.6 version

from prosemirror-dev-toolkit.

Awesome, thank you!

from prosemirror-dev-toolkit.