Comments (15)
@iancoffey This definitely seems like something we should support using Custom Tasks.
I agree that PipelineRun timeout enforcement is a bit of an unknown at the moment. I think one easy way to address this today is just to set a Pipeline's timeout as something really long, like a week or more -- there's probably still some amount of time after which the PipelineRun should be considered expired/invalid if it's still waiting for a gate to unlock to proceed. We could also just allow timeout-less Pipelines that "run" indefinitely -- this becomes a lot easier to imagine when we're talking about "runs" that aren't just container executions.
Anyway, looking forward to hearing more feedback and ideas. Let me know if you'd like to walk through some of the demo tasks I've written to get ideas flowing.
from community.
I still do plan to create a custom task for this at some point, but it has not happened yet. I did implement similar more scoped blocking logic as a catalog task tho! https://github.com/tektoncd/catalog/tree/master/task/prometheus-gate/0.1.
I will close this, and bring it back up when I get around to the custom task. thanks!
from community.
@vdemeester i'm wondering if it makes sense to let this close? I'm not sure @iancoffey is working on it anymore? and it seems like custom tasks are the way we want to go forward here
from community.
Hey @iancoffey ! This sounds very relevant to the custom task work that @imjasonh has been working on: https://github.com/tektoncd/community/blob/master/teps/0002-custom-tasks.md, e.g. this use case sounds very similar (waiting until some condition is met) - I wonder if your proposal could make use of custom tasks?
from community.
@bobcatfish Oh awesome! I had not yet noticed these custom tasks, but I will check into how this concept fits. I think the sharp edge will be around time accounting and managing timeouts correctly when a pause/gate is implemented.
from community.
Im going to contribute this as a catalog Task to start and also see about creating a custom task based on it.
@imjasonh I would def like to hear about the demo custom tasks youve written, that would be
from community.
@imjasonh I would def like to hear about the demo custom tasks youve written, that would be
💯
The two that are most stable (i.e., least complex) so far are wait-task, which takes duration
param and simply waits that long before succeeding, and cel-task, which takes an expression
param and tries to evaluate it, succeeding if the result of evaluation is true
. cel-task will be especially useful when we support custom tasks as conditions.
I'm working on a very basic approval-task that blocks until someone POSTs to some endpoint, and a gcb-task that runs a remote Google Cloud Build with the build config specified in a CRD, and parameterized source context. Those are a bit more complex so they'll probably take a bit longer to stabilize.
from community.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
from community.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
/close
Send feedback to tektoncd/plumbing.
from community.
@tekton-robot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen
.
Mark the issue as fresh with/remove-lifecycle rotten
./close
Send feedback to tektoncd/plumbing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from community.
/remove-lifecycle rotten
/remove-lifecycle stale
/reopen
from community.
@vdemeester: Reopened this issue.
In response to this:
/remove-lifecycle rotten
/remove-lifecycle stale
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from community.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Send feedback to tektoncd/plumbing.
from community.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen
with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
from community.
/remove-lifecycle rotten
from community.
Related Issues (20)
- Have a defined governing body which consists of members from at least 2 different companies.
- Have a documented and publicly accessible description of the project's governance, decision-making, and release processes. HOT 3
- Have a healthy number of committers from at least two organizations. A committer is defined as someone with the commit bit; i.e., someone who can accept contributions to some or all of the project.
- Explicitly define a project governance and committer process. This is preferably laid out in a GOVERNANCE.md file and references a CONTRIBUTING.md and OWNERS.md file showing the current and emeritus committers.
- Have a public list of project adopters for at least the primary repo (e.g., ADOPTERS.md or logos on the project website). HOT 2
- Have achieved and maintained an OpenSSF Best Practices Badge. HOT 1
- Projects that have publicly documented release cycles and plans for Long Term Support ("LTS"). HOT 1
- Decide and document about "end of life" for Tekton projects HOT 1
- Projects that have themselves become platforms for other projects. HOT 1
- Projects that are able to attract a healthy number of committers on the basis of its production usefulness (not simply 'developer popularity'). HOT 1
- Project has undergone a security audit
- Projects that have several, high-profile or well known end-user implementations. HOT 5
- Update roadmaps across all repos HOT 2
- New org for tekton experiments? HOT 13
- Receive a 2/3 supermajority vote from the TOC to move to Graduated stage. HOT 2
- Installation image gcr.io/v2 cann't be access from China. HOT 2
- Propose to make some modifications on top of TEP-0002
- Proposal: adoption of `pipelines-as-code` HOT 9
- New Org for Tekton Verified Catalogs HOT 11
- wlynch govboard access HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from community.