Giter VIP home page Giter VIP logo

Comments (7)

afrittoli avatar afrittoli commented on July 17, 2024 1

+100

This would be useful to simplify how we use conditions today in dogfooding, so I'd be happy to start running the custom task controller in dogfooding from the experimental repo.

from community.

imjasonh avatar imjasonh commented on July 17, 2024 1

+1, happy to co-own and help update and contribute cel-task as a base (or start from scratch if that's better).

🎉

from community.

jerop avatar jerop commented on July 17, 2024 1

+1, happy to co-own and help update and contribute cel-task as a base (or start from scratch if that's better).

yes yes, we can build on it, thanks for your contributions @imjasonh!

some changes I propose we make include:

  • when the CEL expression is valid and is evaluated successfully, the ConditionSucceeded in status of the CELRun is set to True regardless of the expression evaluation result and the CELRun produces a Result representing the expression evaluation result (True/False)
  • when the CEL expression is invalid or any other error is encountered, the ConditionSucceeded in status of the CELRun is set to False

this will allow us to distinguish between errors and the expression evaluating to false, which was one of the issues with Conditions

from community.

imjasonh avatar imjasonh commented on July 17, 2024 1

some changes I propose we make include:

Yeah those both sound like good improvements. 👍

from community.

jerop avatar jerop commented on July 17, 2024

thanks for the quick review @imjasonh and @afrittoli

created the project folder in tektoncd/experimental#691

from community.

jerop avatar jerop commented on July 17, 2024

Common Expression Language Custom Tasks is available in https://github.com/tektoncd/experimental/tree/master/cel

from community.

tekton-robot avatar tekton-robot commented on July 17, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

from community.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.