Giter VIP home page Giter VIP logo

Comments (7)

vincent-pli avatar vincent-pli commented on July 17, 2024

Could we use reflect

from triggers.

bobcatfish avatar bobcatfish commented on July 17, 2024

Could we use reflect

With the caveat that this is something I've heard other people say, and not something I've really experimented with myself, I'm under the impression that using reflection has a significant performance impact. (That and code that uses reflection can be a little confusing to follow!)

from triggers.

vtereso avatar vtereso commented on July 17, 2024

I made a quick prototype using the internal encoding/json library and map[string]interface{}

My prototype approach utilized reflect, but as mentioned, there is a considerable performance impact.

from triggers.

vtereso avatar vtereso commented on July 17, 2024

/assign

from triggers.

bobcatfish avatar bobcatfish commented on July 17, 2024

Another way to tackle this would be to initially target only creation of PipelineResources and PipelineRuns, which would reduce the scope required a bit and we could add support for arbitrary resources later (but if we can get it all at once then great!)

from triggers.

vtereso avatar vtereso commented on July 17, 2024

Another way to tackle this would be to initially target only creation of PipelineResources and PipelineRuns, which would reduce the scope required a bit and we could add support for arbitrary resources later (but if we can get it all at once then great!)

I understood this work item to just be the event side extraction only, which be the logic to set TriggerBinding params

from triggers.

bobcatfish avatar bobcatfish commented on July 17, 2024

I understood this work item to just be the event side extraction only, which be the logic to set TriggerBinding params

Oh good call! My bad, I didn't read it fully and assumed it was about specifying arbitrary templates in the Template - just ignore me 😅

from triggers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.