Comments (5)
Ok, thanks Ian. I'm not extremely knowledgable about those situations where we might want a StatefulSet over a Deployment, but it seems like a Deployment will work well for us right now. Down the line, if we want to change it to a StatefulSet, we can.
from triggers.
From my understanding and according to the docs:
If an application doesn’t require any stable identifiers or ordered deployment, deletion, or scaling, you should deploy your application with a controller that provides a set of stateless replicas. Controllers such as Deployment or ReplicaSet may be better suited to your stateless needs.
Limitations
I think Deployment makes the most sense since there isn't really anything stateful to the listener pods?
from triggers.
@iancoffey do you have an opinion? Was there an advantage to using a StatefulSet for the TektonListener?
from triggers.
iirc, the reasons I chose statefulset are the Ordered, graceful deployment and scaling
and Ordered, automated rolling updates
properties meant it less likely two listeners of different versions be exposed at once. That seemed like a big potential problem at the time.
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#using-statefulsets
I dont have a strong opinion and more or less just rolled with it. The set approach always worked fine but not moreso than a Deployment, in the case that we dont care about the deployment orderings (or I just misunderstand them)
from triggers.
Sorry, I should have closed this earlier from #43
from triggers.
Related Issues (20)
- `namespaceSelector` under `tiggerGroups` will not set `--is-multi-ns=true` on `EventListener` `Pod`. HOT 4
- EventListener loglevel would be more specific HOT 1
- Move Event version to metadata instead of having hard coded version on event type HOT 1
- Support for Default Values in Tekton TriggerBinding Parameters HOT 2
- flaky presence of tekton-generated labels in pipelineRun and taskRun 'Started' cloud events
- Cannot create EventListener with “Timed out waiting on CaBundle to available for Interceptor: empty caBundle in clusterInterceptor spec“
- Required Kubernetes Version HOT 1
- Starting the multiple triggers with Github interceptor is limited by the client rate limiter HOT 2
- Can't install tekton triggers
- Triggers do not include TriggerTemplate labels when creating resources HOT 2
- Functionality is not working after upgrading Triggers from 0.25.x to 0.26.0
- Ability of pipelines eventlistener to handle preflight options request sent for CORS verification HOT 1
- Enable Triggers to create custom non-Tekton resources HOT 4
- EventListener cannot see Triggers in other than deployment namespace HOT 2
- Incorrect swagger.json
- How to give affinity and toleration to Tekton Eventlistner HOT 4
- eventlistener_event_count metric without not status label HOT 1
- Add more cel extensions HOT 5
- Failed to watch *v1beta1.TriggerBinding: unknown (get triggerbindings.triggers.tekton.dev) HOT 2
- Why not to specify TriggerTemplate as resource type? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from triggers.