Proposal to separate Validation / Filtering from TriggerBinding about triggers HOT 3 CLOSED

I like this proposal especially the bit about resources especially doing a single thing well.

Off the top of my head:

• If we go ahead with this proposal, I like the EventParser name a lot!

• I'm not sure I fully understand the difference between Filters and Conditions and why we need both. It seems like they are both validating some conditions are true before the resources get created. Maybe we could use just one (I like Filter)

• The spec.bindings.filterRef syntax in the EventListener YAML is almost exactly the same as using a Condition in a PipelineTask (just replace filterRef with conditionRef). The spec.bindings.conditions syntax also looks similar enough. It seems like we could reuse Conditionals here (maybe just as an implementation detail if we want to keep distinct types like HTTPFilter)

from triggers.

/assign

from triggers.

From the WG today, we are already doing portions of this in #45 and #89 i.e. moving the validation away from TriggerBinding (thanks @khrm ) So, @bobcatfish suggested we close out this proposal and maybe open a new one in the future for Filtering only!

from triggers.