Define policy for modification of TriggerBinding and TriggerTemplate about triggers HOT 10 CLOSED

@vincent-pli Thanks for raising this. I think there are a few points to be considered.

• What about when TriggerBindings and TriggerTemplates are deleted?
• Should we create reconcilers for TriggerBindings and TriggerTemplates to notify the EventListener of changes? Will validation restrict this since modifying one of these resources at a time will invalidate the EventListener trigger?

from triggers.

@vtereso Thanks for your comments.

What about when TriggerBindings and TriggerTemplates are deleted?

This scenario is fatal error, should high light in the status of related EventListener immediately. The pod should keep running.

Should we create reconcilers for TriggerBindings and TriggerTemplates to notify the EventListener of changes? Will validation restrict this since modifying one of these resources at a time will invalidate the EventListener trigger?

I prefer let controller of EventListener to watch TriggerBinding and TriggerTemplate.
In reconciler of EventListener, we could:

• Add specific tag to related TriggerBinding and TriggerTemplate, maybe the value of tag is the resource name of that EventListener
• Watching TriggerBinding and TriggerTemplate
• If related TriggerBinding or TriggerTemplate updated or deleted, the reconciler will triggered, then do validation and take action.

from triggers.

I think about the solution today, the implementation will be complex. is that worth 🤔 ?

from triggers.

I think about the solution today, the implementation will be complex. is that worth 🤔 ?

I think it makes sense to keep this issue open since it also falls under the umbrella of #35, but I agree it is non-trivial to implement.

from triggers.

Summary the solution here:

1. In reconcile of EventListener add specific tag to TriggerTemplate and TriggerBinding.
2. Record the Generation of TriggerTemplate and TriggerBinding to the EventListener.status.generations
3. Watch the TriggerTemplate and TriggerBinding, when update occurred, the related EventLister (find by the label added in step 1) will enter the work queue.
4. In reconcile, check the Generation between TriggerTemplate.Generation and EventListener.status.generations, if not same, take action (emit event or whatever)

from triggers.

Hi guys, the implements is not follow the upper design, more simple:

1. Start watcher in the pod which created by EventListener, the watcher will watch on related TriggerBinding and TriggerTemplate.
2. If any Delete and Update occurred on related TriggerBinding and TriggerTemplate, a k8s event will be send and bind to related EventListener

from triggers.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

from triggers.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

from triggers.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

from triggers.

@tekton-robot: Closing this issue.

from triggers.