Giter VIP home page Giter VIP logo

Comments (46)

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

This is sadly not an issue I can fix as I do not touch the end at all. It seems you have an end overhaul mod on that is grabbing Bumblezone’s biomes when it should not be. You should contact whatever end mod you have on to let that dev know their biome source is broken and needs tweaking.

But just wondering, what end mods you have on?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

outer ends and endergetic

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

What the

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

Only thing I can think to ask is if the bumble zone biomes are marked as end boomes?

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

@GiantLuigi4 nope

My biomes are None type which make it stranger. It could be someone's biome source is broken in such a way that they return the wrong int biome ID from the layers which then is resolved to my biome. Commonly caused by people not using the dynamicregistry for biomes in their layers

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

Yeah even if they were marked as end biomes, I don’t think abnormals core would automatically add them to the biome pool. Pretty sure you need to manually register them for generation with abnormals.

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

tried chocolate fix as well and it didnt work

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

The reason chocolate didnt work is because this isn't a biome shuffling issue. That only happens for existing chunks and all a biome shuffling affects is the biome's colors and mob spawns. Not actual biome generation.

I cant reproduce this myself tho with endergetic, outer end, and bumblezone on. Are you able to export your modlist entirely? maybe another mod is needed to be on in order for this conflict to occur?

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

On the third issue opened relating to this, it does say on servers

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

https://www.curseforge.com/minecraft/modpacks/skyopolis-4

this mod pack, the end in single player works fine its only on servers

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

ok so with only those 3 mods bumblezone, Endergetic expansions and outer ends the bug still happens. i have a server up right now if you wanna see first hand

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

No I believe you. I just cant seem to make the bug happen on my own server which is weird. Bugs that only occur randomly is a pain to debug. Hopefully Abnormal Core can figure out the cause
image

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

its super strange, the outer ends biomes and the endergetic biomes do not spawn

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

however these do
image

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Looks like bagel linked you a ATM6 post about Forge updating and all. What version of Forge are you using for the server?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

36.0.39 i can try updating it

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Hmm. Your forge version isnt the issue then. And you are making a new world to test the end each time right?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

yep, second normal world has outer ends but not endergetic?

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Here's a long shot. No idea if this will work but lets give it a try. Delete your config folder on the server so that it resets back to defaults. Maybe a broken config is doing this?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

of the bumblezone or all of them

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

All the configs. You can move the entire config folder to a different place as temporary storage if you dont want to nuke it entirely

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

ok

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

so i did have a default config for the bumble zone

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

but everything removed still happening

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Dang. That was my last suggestion. I got nothing now. Wtf is going on?

I’m curious tho, if you swap Bumblezone for The Undergarden mod, does The Undergarden biomes spawn in the end instead of bumblezone’s?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

do you want me to test lol?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

image

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

#56 (comment) Those things are not a biome, they just generate sometimes

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

You can test if you want but I think you did more than enough work already on this lol. Still, it’s annoying I can’t get it to happen myself.

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

but they still can be found without the bumblezone mod installed, those commands work

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

If you were to make a vanilla worldgen datapack which just adds a single biome, and use it on server with just outer end, abnormals core, and endergetic, would the same thing occur?

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

here's a datapack that has 60+ new biomes (I just took the vanilla worldgen pack and change the minecraft folder to custom so now it is "custom:badlands" and all to make new biomes)
testworldgenpack.zip

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

where does it go inside the worlds data pack?

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

image
working???
image

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Just checked and the modpack is indeed using the latest abnormals core, endergetic, and bumblezone. Outer end is 4 versions behind but i doubt the issue is caused by that.

Where are you running the server on? Some places like Mohist is know to wreck mods

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

bisect hosting is the main server but im testing by running a server off home pc

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Ok so server is fine

from bumblezone.

GiantLuigi4 avatar GiantLuigi4 commented on June 15, 2024

Wack issue you got here

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

This is the absolutely last thing I can think of. Try this bumblezone jar. I registered my biomes at mod startup with dummy biomes and the json overrides it later. This jar disables that dummy biome creation and registering.
the_bumblezone-1.16.5-2.2.16b.zip

If this jar work, then something in abnormals isn't working properly I think for code biomes being overriden by json biomes. Which is a problem as some people do this to make json biomes spawn in the overworld with forge's BiomeManager hook. And of course, people also use datapacks too to override biomes.

If this jar doesnt work, I'm am gonna get a drink of water and walk away from this cursed issue report lmao

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

trying now really hopeing it works haha

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

well well well its working

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

i deleted the end and added the updated mod and its also working on the server as well

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

yep then it's a registry issue in abnormal's end biome provider layer most likely. Issue probably would occur with many other mods that uses dummy biomes to spawn json biomes in the overworld.

from bumblezone.

benbenlaw avatar benbenlaw commented on June 15, 2024

image
the new generation in the box overridding the old map seems all good thanks :)

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

I know what the issue is @GiantLuigi4
They need to override this method and swap the biome parsing inside to use the dynamic register passed in first before trying to resolve the biome with BiomeRegistry.getKeyFromID.
https://github.com/team-abnormals/abnormals-core/blob/601548fd273d8eac75ed56b961343a9559fbe58d/src/main/java/com/minecraftabnormals/abnormals_core/core/mixin/EndBiomeProviderMixin.java#L64

that issue caused me so much pain in bumblezone which is why I fixed it by making my own sampling method

public Biome sample(Registry<Biome> registry, int x, int z) {
int resultBiomeID = ((LayerAccessor)this.BIOME_SAMPLER).bz_getSampler().getValue(x, z);
Biome biome = registry.getByValue(resultBiomeID);
if (biome == null) {
if (SharedConstants.developmentMode) {
throw Util.pauseDevMode(new IllegalStateException("Unknown biome id: " + resultBiomeID));
} else {
RegistryKey<Biome> backupBiomeKey = BiomeRegistry.getKeyFromID(0);
Bumblezone.LOGGER.warn("Unknown biome id: ${}. Will spawn ${} instead.", resultBiomeID, backupBiomeKey.getLocation());
return registry.getValueForKey(backupBiomeKey);
}
} else {
return biome;
}
}

from bumblezone.

TelepathicGrunt avatar TelepathicGrunt commented on June 15, 2024

Closing now as latest Abnormals Core update has fixed the issue!

from bumblezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.