Giter VIP home page Giter VIP logo

Comments (2)

vladnicula avatar vladnicula commented on May 23, 2024

Some parts can, but there's one or two packages that are async. I think we are using the babel generator with a async callback that gets called when babel is done with it.

I'm certain we CAN make them sync as even the babel generator has a sync mode.

I'm also certain we SHOULD NOT make them sync as sync scales less well, and my assumption is that we might want to multithread the architecture to allow multiple components to be generated concurrently via worker threads / service workers.

from teleport-code-generators.

paulbrie avatar paulbrie commented on May 23, 2024

@vladnicula what about having both like in the node API?

This would allow to transform this:

const teleport = require('@teleporthq/teleport-code-generators')

const reactGenerator = teleport.createReactComponentGenerator()
const uidl = {
  name: 'DemoComponent',
  content: {
    type: 'text',
    children: ['Teleport World!']
  }
}

reactGenerator
  .generateComponent(uidl)
  .then(({ dependencies, code }) => {
    console.log(dependencies)
    console.log(code)
  })
  .catch(err => {
    console.log(err)
  })

into this

const teleport = require('@teleporthq/teleport-code-generators')

const reactGenerator = teleport.createReactComponentGenerator()
const uidl = {
  name: 'DemoComponent',
  content: {
    type: 'text',
    children: ['Teleport World!']
  }
}

const { dependencies, code } = reactGenerator.generateComponentSync(uidl)

from teleport-code-generators.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.