Giter VIP home page Giter VIP logo

Comments (11)

EddyVerbruggen avatar EddyVerbruggen commented on September 18, 2024

You can use any standard JS lib with TS so I don't get the point. If you want to contribure a .d.ts file that would be great of course.

from mapbox.

 avatar commented on September 18, 2024

I am facing the same issue
I am developing an app using Ionic 2 and typescript.
I want to use this plugin but get the same issue.
Do you have any solution?

from mapbox.

risinghero avatar risinghero commented on September 18, 2024

Hi, @peridotlib15 . Simplest solution is to declare Mapbox variable in .ts file before module or namespace declaration. Like below.

declare var Mapbox: any;

from mapbox.

risinghero avatar risinghero commented on September 18, 2024

Wow, actually I implemented typescript definition file and forgot about it. It's in attachment - rename it to mapbox.d.ts
mapbox.txt

from mapbox.

EddyVerbruggen avatar EddyVerbruggen commented on September 18, 2024

Can you be bothered to send a PR perhaps? Thanks for sharing anyway!

from mapbox.

risinghero avatar risinghero commented on September 18, 2024

I'll do PR. But first of all I'll add all functions to TypeScript definition file. Currently there is only part of them.

from mapbox.

risinghero avatar risinghero commented on September 18, 2024

@EddyVerbruggen I've added typescript definition file to PR

from mapbox.

cusspvz avatar cusspvz commented on September 18, 2024

@Anothar do you mind to add it on a different PR? It seems that you have lots of contributions, which is awesome!! But for faster PR landing, i would recommend you to divide them on PRs/branches.

Inspite of it, I'm gonna try to cherry pick your commit into a new PR so we don't have to re-open this issue.

from mapbox.

cusspvz avatar cusspvz commented on September 18, 2024

@Anothar done it.

from mapbox.

vbudilov avatar vbudilov commented on September 18, 2024

@cusspvz -- Hello! Any idea when 1.3.0 is going to be released? Trying to integrate this plugin with Ionic3 but it's not as clear-cut as I thought.

Thanks...

from mapbox.

ansarikhurshid786 avatar ansarikhurshid786 commented on September 18, 2024

@vbudilov is it working with ionic 3?

from mapbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.