Remove need for ctrl button? about vimari HOT 10 CLOSED

The reason that Ctrl is required at the moment is to stop vimari being triggered when you are trying to edit something on the page (e.g. a text box).

The chrome version that this is based on (vimium) goes into an 'insert' mode when you select an editable DOM element. This then disables the link hinting, so when you type 'f' it actually types it rather than entering the link hint mode.

In order to remove the need for the Ctrl button, the same thing will need to be implemented.

I have been meaning to implement this for a while, but have struggled to get enough time together to do it. If you would be happy to fork and work on this it would be a real help.

I am also really keen to implement some of the other features that this project is lacking from the chrome version. Unfortunately the chrome version has developed to a point where I dont think it is feasible to merge code into this project, but I would like to copy some more of the features across. I will be setting up some tickets at some point this week as trackers.

from vimari.

Looks like @ChrisLTD did this and more, and a basic skim looked like up to and including https://github.com/ChrisLTD/vimkitten/commit/6420bd9446538bb9e8df8a7c83f328b29c1a3333 was pretty useful. After that he decided to officially fork the project, adding himself as the author and renaming it to something about cats :-/ However, might be useful.

from vimari.

I should add that if you document the development process, I would test or develop it and send a pull request. Figuring out the development logistics is over my commitment level, it seems.

from vimari.

Ok, I will take a look at this again and see what can be done. I am travelling at the moment, so it will have to wait for next week but can't see a reason why we couldn't merge @ChrisLTD's changes

from vimari.

Hey @guyht @woahdae
I'm happy to help try to merge the changes back, or at least work on Vimari once they are in. I played around with rebranding it just for the hell of it, and I'm sorry if I ruffled any feathers. At this point, I don't have any intentions of trying to push my version to a wider audience and would rather work with Vimari.

I will tell you that my version is far from bug free. I have code in place to try to prevent the plugin from stealing keystrokes when you're in an editable DOM element but it doesn't work perfectly, and I couldn't figure out quite how to port the more robust checks from Vimium. That's why I ended up adding a blacklist to the plugin preferences. I also toyed with the idea of adding a keystroke to toggle the plugin at will.

from vimari.

I personally like the current Vimari implementation much more than having just 'f' trigger link hinting. For instance I have the extension 'KeyStroke' setup to use 'f' for scrolling down but there are other reasons I will explain later if 'f' is implemented and the option for 'ctrl + f' mapping is not an option.

If Vimari had the same customization options as Vimium, where you can apply any key or 'modifier + key' to any action then making this the default would not be a problem, as users like myself could specify to use 'control + f' instead of just 'f' and go back to the way vimari previously worked.

I know I am only expressing my own wishes so I am not looking for a debate as to which method is better as that is subjective and you all may be correct... I only wanted to point out that some users, like myself, enjoy the current implementation very much.

@guyht all I ask is that if you implement this request, please make it possible for us to map link hinting and link hinting in a new tab back with control, I know ChrisLTD's has this option. One other thing if you add more vim-like features, give us the options to disable those actions we don't want/need from the extensions preferences, give us a checkbox or the actual fields to leave blank That would be very much appreciated and I hope it is not too much to ask.

Vimari currently works great, so before making it buggy and having to use blacklists, please consider not implementing this feature until it has become more stable and the keybinding options to revert back are there.

If it ain't broke, don't fix it.

from vimari.

Sorry for the delay in replying, been abroad for a couple of days.

@tzarskyz yes, if @ChrisLTD's changes are merged we would also need to maintain backwards compatibility.

Vimari isnt broken, but I do agree that forcing the 'CTRL' button is a limitation of the plugin. While there are good reasons (#3 (comment)) for the limitation, it would also be nice to have alternative solutions available.

So. If someone is prepared to do the work, I will fully support it, so long as the current functionality is the default and the changes are 100% backwards compatible. I.e. when users update the plugin, they wont notice the change, but will have the option to turn it on in the settings.

@ChrisLTD no feathers ruffled, vimari is open source, and any is free to do what they like with it :)

from vimari.

if #8 is accepted, https://github.com/woahdae/vimari/tree/working implements this and a couple other things (and maintains backwards compatibility). I don't want to get too ahead without checking with what people think, since I'd rather do something that would be taken upstream than maintain my own branch, so feedback is welcome.

from vimari.

Awesome work, thanks Woody. Going to check through this over the weekend
and hopefully get a new release out.

G

On Friday, July 27, 2012, Woody Peterson wrote:

if #8 is accepted,
https://github.com/woahdae/vimari/tree/working implements this and a
couple other things (and maintains backwards compatibility). I don't want
to get too ahead without checking with what people think, since I'd rather
do something that would be taken upstream than maintain my own branch, so
feedback is welcome.

---

Reply to this email directly or view it on GitHub:
#3 (comment)

from vimari.

Marking as resolved thanks to Woody's changes

from vimari.