Giter VIP home page Giter VIP logo

Comments (13)

Mazyod avatar Mazyod commented on May 14, 2024

Thanks for reporting the problem!
The issue is that the component tries to add the extension view as a subview of associated view controller, which is in your case, a UITableViewController. This means the extension view is being added as a subview of a UITableView, which screws everything up.

I am looking into a better solution now that should help resolve this problem.

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

Apparently, if you access self.topLayoutGuide on UITableViewController, everything screws up... I don't know why..

from tlyshynavbar.

insanj avatar insanj commented on May 14, 2024

Checking in to report this problem as well. Implementing the example setups in a UITableViewController prevents any scrolling expect for elastic/bounce, and doesn't work as intended. No combination of existing controller and tableView seem to work, and I haven't accessed the self.topLayoutGuide property anywhere in my codebase.

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

@insanj The access to topLayoutGuide is made from within the component, and is quite necessary.

from tlyshynavbar.

insanj avatar insanj commented on May 14, 2024

@Mazyod Ah, I didn't realize that. My knowledge of the underworkings of UITableViewControllers feels quite barren, now! Excited to use TLYShyNavBar in production once this gets resolved.

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

@insanj Oh, sorry no. I meant used within the TLYShyNavBar component, not UITableViewController. I will hopefully look into this soon, but you can try what another user did, he migrated to a UIViewController, and added the tableView as a subview. If you can't or prefer to use UITableViewController, that's cool, too. I just need some time to look into it. It's unfortunately not straight forward.

from tlyshynavbar.

insanj avatar insanj commented on May 14, 2024

@Mazyod Thanks for the clarification. That's actually how I initially structured the view controller in question, but I migrated to using a UITableViewController to utilize refreshControl more conveniently. It might be worth going backwards for the performance and beauty of TLYShyNavBar, though. Thanks for your efforts, either way.

from tlyshynavbar.

basilmariano avatar basilmariano commented on May 14, 2024

Hi,

@Mazyod , I really like your very nice library and actuallyI am using it now in my current project :)
But there is a problem on pushViewController, the extensionView shows when I push, but it is actually hidden..

I saw your .gif sample, it works well in GIF but in actual implemetation it doesn't, I dont know what I am doing wrong. Can you pls help me master

from tlyshynavbar.

jodyheavener avatar jodyheavener commented on May 14, 2024

Any progress on this? Would love to get this working with my UITableViewController as I can't do the recommended approach of adding a UITableView to UIViewController

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

@jodyheavener Personally, I can't justify spending work hours on this project for the time being, since we are not using the component this way. On the side, I can't find time to develop it. Of course, since this is a very demanded feature, I'll do my best to review any PRs on this front ASAP, and give feedback as well as discuss it, if necessary. I'm available on twitter @Mazyod.

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

Since the repo has a UITableViewController example now, I suppose this issue should be closed. If there are any more specific issues, please reopen or specify the exact issue

from tlyshynavbar.

rrallo avatar rrallo commented on May 14, 2024

So is the only workaround to migrate to a ViewController with a tableview inside of it? This issue only happens to me on iOS 7.1.

Amazing job on the repo though!

from tlyshynavbar.

yuchaozh avatar yuchaozh commented on May 14, 2024

I met the same issue right now. Where is the example for UITableViewController?

from tlyshynavbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.