Comments (13)
Thanks for reporting the problem!
The issue is that the component tries to add the extension view as a subview of associated view controller, which is in your case, a UITableViewController
. This means the extension view is being added as a subview of a UITableView
, which screws everything up.
I am looking into a better solution now that should help resolve this problem.
from tlyshynavbar.
Apparently, if you access self.topLayoutGuide
on UITableViewController
, everything screws up... I don't know why..
from tlyshynavbar.
Checking in to report this problem as well. Implementing the example setups in a UITableViewController
prevents any scrolling expect for elastic/bounce, and doesn't work as intended. No combination of existing controller and tableView
seem to work, and I haven't accessed the self.topLayoutGuide
property anywhere in my codebase.
from tlyshynavbar.
@insanj The access to topLayoutGuide
is made from within the component, and is quite necessary.
from tlyshynavbar.
@Mazyod Ah, I didn't realize that. My knowledge of the underworkings of UITableViewControllers
feels quite barren, now! Excited to use TLYShyNavBar
in production once this gets resolved.
from tlyshynavbar.
@insanj Oh, sorry no. I meant used within the TLYShyNavBar
component, not UITableViewController
. I will hopefully look into this soon, but you can try what another user did, he migrated to a UIViewController
, and added the tableView as a subview. If you can't or prefer to use UITableViewController
, that's cool, too. I just need some time to look into it. It's unfortunately not straight forward.
from tlyshynavbar.
@Mazyod Thanks for the clarification. That's actually how I initially structured the view controller in question, but I migrated to using a UITableViewController
to utilize refreshControl
more conveniently. It might be worth going backwards for the performance and beauty of TLYShyNavBar, though. Thanks for your efforts, either way.
from tlyshynavbar.
Hi,
@Mazyod , I really like your very nice library and actuallyI am using it now in my current project :)
But there is a problem on pushViewController, the extensionView shows when I push, but it is actually hidden..
I saw your .gif sample, it works well in GIF but in actual implemetation it doesn't, I dont know what I am doing wrong. Can you pls help me master
from tlyshynavbar.
Any progress on this? Would love to get this working with my UITableViewController as I can't do the recommended approach of adding a UITableView to UIViewController
from tlyshynavbar.
@jodyheavener Personally, I can't justify spending work hours on this project for the time being, since we are not using the component this way. On the side, I can't find time to develop it. Of course, since this is a very demanded feature, I'll do my best to review any PRs on this front ASAP, and give feedback as well as discuss it, if necessary. I'm available on twitter @Mazyod.
from tlyshynavbar.
Since the repo has a UITableViewController example now, I suppose this issue should be closed. If there are any more specific issues, please reopen or specify the exact issue
from tlyshynavbar.
So is the only workaround to migrate to a ViewController with a tableview inside of it? This issue only happens to me on iOS 7.1.
Amazing job on the repo though!
from tlyshynavbar.
I met the same issue right now. Where is the example for UITableViewController?
from tlyshynavbar.
Related Issues (20)
- Not hide nav hide text only
- Navigation bar corrupted (can recreate in TLYShyNavBarDemo)
- Issue when adding/removing navigationItems while navigation bar is contracted
- Fade the entire navbar can not work when use tableview
- the code works not well in pageViewcontroller HOT 1
- Multiple extensionViews
- bug HOT 1
- Nav Bar gets stuck midway through transition state when using the interactivePopGestureRecognizer HOT 2
- When I click on the status bar twice, the effect is different.
- Statusbar is gone / get "overlapped" HOT 4
- TLYShyNavBar not working, UITabBarController HOT 1
- -[UIViewController tly_swizzledViewWillAppear:]: unrecognized selector sent to instance 0x10355e750
- Cannot work on iPhone X. HOT 5
- iOS 11 Large gap above scroll view HOT 6
- iOS 11 Fade no longer works HOT 4
- Is there no way to have navBar in the same state it was it when a view controller was pushed to it?
- Hiding/Expanding navigationbar is not working on ios 11 with xcode 9
- Failed to Render and update auto layout status for MYViewController HOT 1
- Support for iOS 12 and Xcode 10 beta HOT 1
- Extra distance between UINavigationBar and ExtensionView after a rotation. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tlyshynavbar.