Comments (4)
@DimaVartanian Thanks for your kind words. I am really impressed by the Spark inspector approach using a jailbroken device, never thought of that!
So, about the idea, I am sold. Anything to improve this component, will improve our app experience anyways :)
Here is an initial rough experiment I did:
I think I used an easier way than playing with backgrounds and views. I set the navigation bar as hidden on viewWillDisappear:
if it is contracted, and unhide it in the next view viewWillAppear:
. This makes UIKit
take care of the animation for us. I still have some concerns, though, so gonna look deeper into it soon.
from tlyshynavbar.
This looks great and more natural than before for sure! So the only discrepancy in behavior now is that when you pop back to the original view, the navigation bar is always reset to the open state rather than going back to the state it was in when you pushed. This is really just a difference in behavior and not a usability issue like the other one was so it might not be very important or even needed. In any case, I'll take a look soon when I get a chance as well :).
from tlyshynavbar.
Thanks, I meant to address the second point, but got dragged in by the first issue. I think it's a very simple matter to reserve the previous state. Honestly, I would keep it the way it is in our app, but an option can be added to reserve the last state for users to choose between the two.
My reason behind making it expand is that I feel the user probably went back using the back button, hence he is focused on the navigation bar. Taking that bar away, even though that's the initial state, might not be ideal for that case. I can see it working better in other cases, though.
from tlyshynavbar.
I thought it was simple, but issues kept popping up.. Need to take a closer look at it.
from tlyshynavbar.
Related Issues (20)
- Not hide nav hide text only
- Navigation bar corrupted (can recreate in TLYShyNavBarDemo)
- Issue when adding/removing navigationItems while navigation bar is contracted
- Fade the entire navbar can not work when use tableview
- the code works not well in pageViewcontroller HOT 1
- Multiple extensionViews
- bug HOT 1
- Nav Bar gets stuck midway through transition state when using the interactivePopGestureRecognizer HOT 2
- When I click on the status bar twice, the effect is different.
- Statusbar is gone / get "overlapped" HOT 4
- TLYShyNavBar not working, UITabBarController HOT 1
- -[UIViewController tly_swizzledViewWillAppear:]: unrecognized selector sent to instance 0x10355e750
- Cannot work on iPhone X. HOT 5
- iOS 11 Large gap above scroll view HOT 6
- iOS 11 Fade no longer works HOT 4
- Is there no way to have navBar in the same state it was it when a view controller was pushed to it?
- Hiding/Expanding navigationbar is not working on ios 11 with xcode 9
- Failed to Render and update auto layout status for MYViewController HOT 1
- Support for iOS 12 and Xcode 10 beta HOT 1
- Extra distance between UINavigationBar and ExtensionView after a rotation. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tlyshynavbar.