Giter VIP home page Giter VIP logo

Comments (4)

Mazyod avatar Mazyod commented on May 14, 2024

@DimaVartanian Thanks for your kind words. I am really impressed by the Spark inspector approach using a jailbroken device, never thought of that!

So, about the idea, I am sold. Anything to improve this component, will improve our app experience anyways :)

Here is an initial rough experiment I did:

I think I used an easier way than playing with backgrounds and views. I set the navigation bar as hidden on viewWillDisappear: if it is contracted, and unhide it in the next view viewWillAppear:. This makes UIKit take care of the animation for us. I still have some concerns, though, so gonna look deeper into it soon.

from tlyshynavbar.

DimaVartanian avatar DimaVartanian commented on May 14, 2024

This looks great and more natural than before for sure! So the only discrepancy in behavior now is that when you pop back to the original view, the navigation bar is always reset to the open state rather than going back to the state it was in when you pushed. This is really just a difference in behavior and not a usability issue like the other one was so it might not be very important or even needed. In any case, I'll take a look soon when I get a chance as well :).

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

Thanks, I meant to address the second point, but got dragged in by the first issue. I think it's a very simple matter to reserve the previous state. Honestly, I would keep it the way it is in our app, but an option can be added to reserve the last state for users to choose between the two.

My reason behind making it expand is that I feel the user probably went back using the back button, hence he is focused on the navigation bar. Taking that bar away, even though that's the initial state, might not be ideal for that case. I can see it working better in other cases, though.

from tlyshynavbar.

Mazyod avatar Mazyod commented on May 14, 2024

I thought it was simple, but issues kept popping up.. Need to take a closer look at it.

from tlyshynavbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.