Giter VIP home page Giter VIP logo

Comments (11)

wangtz avatar wangtz commented on July 19, 2024

Sound reasonable to me.

Any thoughts @yyoon and @lu-wang-g ?

Thanks,
Tiezhen

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

Sounds good to me.

@lu-wang-g @xunkai55 Should we push a new version with this change?

from tflite-support.

lu-wang-g avatar lu-wang-g commented on July 19, 2024

A new version will be great! As we are soon releasing TFLite Support 2.5 on the Java side, so it will be great to push for a new Cocoapods version. @xunkai55 is the Cocoapods release under your plan?

Also, is it possible to pin to the major version as suggested?

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

A new version will be great! As we are soon releasing TFLite Support 2.5 on the Java side, so it will be great to push for a new Cocoapods version. @xunkai55 is the Cocoapods release under your plan?

I think we should rather publish 0.1.1 ASAP with only the dependency constraint change from 0.1.0. This should unblock any users having the same issues right now. I can proceed with that if you're okay with it.

Also, is it possible to pin to the major version as suggested?

Yes, that's well supported by CocoaPods, as suggested by @tinder-owenthomas. I'd prefer we specify ~> 2.2.1 as we haven't really tested it between [2.0.0, 2.2.1).

from tflite-support.

lu-wang-g avatar lu-wang-g commented on July 19, 2024

@yyoon sounds good! Actually, it's not TFLite Support 2.5; it's TFLite Support 0.2, which depends on TFLite 2.5. But anyway, 0.1.1 sounds good to me. Thanks a lot!

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

@tinder-owenthomas I've just published TensorFlowLiteTaskText pod version 0.1.1 with the modified dependency constraint.

I'm closing this for now, but please feel free to reopen if the issue hasn't been properly resolved.

from tflite-support.

tinder-owenthomas avatar tinder-owenthomas commented on July 19, 2024

Thanks for looking into this @yyoon!

It looks like right now it is pinned at ~> 2.2.1 which will allow for patch updates, but only as far as 2.2.2 (as that's the last 2.2 patch they issued). Any chance we can pin at ~> 2.2 without the patch specifier to allow any 2.x.x version? Google is up to 2.3.1 now which is what our other dependencies are looking for, and will presumably bump to 2.4.x in the near future - but assuming they are following proper semantic versioning there will not be breaking changes until they go to a new 3.x.x major version so any 2.x.x should be ok.

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

Oh, somehow I didn't realize CocoaPods would lock the minor version as well when specifying the patch.
Yeah, the intended behavior is the one you described with ~> 2.2. I'll try updating this again and let you know.

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

@tinder-owenthomas This should be fixed by now. Could you repo update and try again?

from tflite-support.

tinder-owenthomas avatar tinder-owenthomas commented on July 19, 2024

Seems to be working. Thank you!

from tflite-support.

yyoon avatar yyoon commented on July 19, 2024

Thanks for confirming!

from tflite-support.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.