Giter VIP home page Giter VIP logo

Comments (10)

terkelg avatar terkelg commented on July 29, 2024

Thanks for reporting this.
I don't have access to a windows machine. It it possible that you can help out out?

from ramme.

BoredMind avatar BoredMind commented on July 29, 2024

This is happening for me as well. Whatever help you need let me know and I'll help out.

from ramme.

vintagesucks avatar vintagesucks commented on July 29, 2024

Happening for me as well. I think the expected result after closing the window would be Ramme being minimized to the system tray, but instead it's just disappearing in the background as described by @antonyrod. The real issue here is the missing tray icon, I guess.

Ramme 2.0.0, Windows 10 Pro 10.0.10240.0 (64bit)

from ramme.

terkelg avatar terkelg commented on July 29, 2024

Hey @BoredMind, I need your help. And you too @antonyrod. Can you guys test the latest dev branch? I think I've found the bug. If not, you're more than welcome to contribute to this one @BoredMind.

Here's a link to the dev branch
https://github.com/terkelg/ramme/tree/dev

I think I've found the bug πŸŽ‰

from ramme.

BoredMind avatar BoredMind commented on July 29, 2024

@terkelg Do you have a Windows build from the dev branch? I don't have a system setup with Electron to build it right now.

from ramme.

vintagesucks avatar vintagesucks commented on July 29, 2024

@terkelg The issue @antonyrod described is still present in the latest dev branch, but as I said, I think running in the background after closing the window is a feature, not a bug. From the Ramme README:

Background behavior

When closing the window, the app will continue running in the background, in the dock on macOS and the tray on Linux/Windows. Right-click the dock/tray icon and choose Quit to completely quit the app.

The only thing that is missing here is a way to quit Ramme (β†’ the described tray icon) and PR #21 should solve this when refactored into a seperate file.

from ramme.

terkelg avatar terkelg commented on July 29, 2024

You're rightβ€š @vintagesucks. The app is actually designed to run in the background. However, I didn't know the tray was required to quit on Windows. Let's add the tray menu. Please see my comment on the pull request #21

from ramme.

vintagesucks avatar vintagesucks commented on July 29, 2024

@terkelg Refactored into tray.js, see PR #23. Please note that I could test/optimize the tray icon toggle functionality for Windows only, so feel free to change the behavior depending on the platform. The Windows tray works quite different compared to the OS X toolbar, I'd suspect.

from ramme.

terkelg avatar terkelg commented on July 29, 2024

Should be fixed with commit 19bd1f7. Please test the latest master branch to confirm πŸ‘

from ramme.

vintagesucks avatar vintagesucks commented on July 29, 2024

@terkelg This is fixed in the latest master branch. πŸ‘

from ramme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.