Giter VIP home page Giter VIP logo

Comments (7)

antonbabenko avatar antonbabenko commented on July 26, 2024 1

@danielsepulvedab @svenlito Can this be closed now since yesterday's release of 4.17.0?

from terraform-aws-notify-slack.

antonbabenko avatar antonbabenko commented on July 26, 2024 1

Thank you very much for your code changes, too!

Do not hesitate to review other open issues/prs if you have the possibility and tag my name if you think they are good to be merged.

from terraform-aws-notify-slack.

danielsepulvedab avatar danielsepulvedab commented on July 26, 2024

I also wanted to use this module to send EventBridge events to Slack. As @keelefi said the result message is just a JSON. Also I had to manually change the policy for the SNS topic to give events.amazonaws.com permission to publish to there. It would be nice if that also gets included here.
I could try to put up a PR if there's interest to merge it here.

from terraform-aws-notify-slack.

svenlito avatar svenlito commented on July 26, 2024

@danielsepulvedab please go ahead with your PR! :)

from terraform-aws-notify-slack.

danielsepulvedab avatar danielsepulvedab commented on July 26, 2024

Actually this already had been addressed in #124. So after the release v4.11.0 the messages should look better. Nevertheless there are still some formatting issues for nested messages that I tried to address in #142

from terraform-aws-notify-slack.

danielsepulvedab avatar danielsepulvedab commented on July 26, 2024

Yes. Thanks for the release!

from terraform-aws-notify-slack.

github-actions avatar github-actions commented on July 26, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-aws-notify-slack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.