Comments (8)
I will take a look at this later today or tomorrow.
from terraform-aws-notify-slack.
I am looking into this issue now and the solution proposed in #98 is too simple and does not work for several situations.
I propose to have the following:
- Users of Terraform 0.12 with AWS Provider 3 to use this module v3.4.0.
- Users of Terraform 0.13 can use the latest version of this module where Lambda module is the most up-to-date, and
depends_on
which became available in Terraform 0.13 is used for that.
If there are no objections, I will make a new release now.
from terraform-aws-notify-slack.
@antonbabenko would #98 be an acceptable fix or did you have something else in mind?
Initially, I wanted to delegate the entire CloudWatch log creation to the Lambda module but then I saw your comment so decided to the one in this module instead.
# Do not use Lambda's policy for cloudwatch logs, because we have to add a policy
# for KMS conditionally. This way attach_policy_json is always true independenty of
# the value of presense of KMS. Famous "computed values in count" bug...
from terraform-aws-notify-slack.
same error here
Error: Creating CloudWatch Log Group failed: ResourceAlreadyExistsException: The specified log group already exists: The CloudWatch Log Group '/aws/lambda/slack_ooh-major' already exists.
on .terraform/modules/slack_ooh-major.lambda/terraform-aws-lambda-1.18.0/main.tf line 109, in resource "aws_cloudwatch_log_group" "lambda":
109: resource "aws_cloudwatch_log_group" "lambda" {
which is associate with the below rescources
resource "aws_cloudwatch_log_group" "lambda" {
count = var.create && var.create_function && ! var.create_layer && ! var.use_existing_cloudwatch_log_group ? 1 : 0
name = "/aws/lambda/${var.lambda_at_edge ? "us-east-1." : ""}${var.function_name}"
retention_in_days = var.cloudwatch_logs_retention_in_days
kms_key_id = var.cloudwatch_logs_kms_key_id
tags = merge(var.tags, var.cloudwatch_logs_tags)
}
i will suggest a variable cloudwatch_log_group
which will be default = false
only if create_sns_topic then create a new cloudwatch_log_group
with name same sns_topic_name
or what they want
from terraform-aws-notify-slack.
There is v4.0.0 - for Terraform 0.13 users, and v3.4.0 - for Terraform 0.12 users.
Please let me know if there are any issues related to this upgrade.
from terraform-aws-notify-slack.
That’s much better @antonbabenko thank you. Wasn’t sure on the approach you usually take for managing multiple TF versions.
from terraform-aws-notify-slack.
thanks @antonbabenko , is working
from terraform-aws-notify-slack.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
from terraform-aws-notify-slack.
Related Issues (20)
- Noisy output HOT 4
- Support @here in Slack Notifications HOT 6
- lambda-runtime configurable HOT 3
- Make lambda logging level configurable HOT 3
- The link to the CloudWatch alarm is no longer valid. HOT 10
- SNS Feedback role is broken HOT 7
- Messages to slack are not delivered HOT 2
- Add formatting for Security Hub findings HOT 3
- Have a more descriptive Slack CloudTrail notification format HOT 3
- Apply fails when multiple module calls are used HOT 2
- Provider produced inconsistent final plan in CI/CD environment HOT 4
- AWS Lambda runtime python3.8 deprecation HOT 10
- SNS Feedback role is broken HOT 4
- Add formatter for Security Hub Findings HOT 4
- Add variable for Lambda Architecture to support ARM HOT 1
- Add formatter for Amazon Managed Prometheus alerts HOT 4
- Expected runtime expects Python 3.9 but locally using 3.11 HOT 1
- Lambda function isn't attaching to the specified VPC HOT 3
- Lambda version updates not reflected in trigger HOT 1
- Trigger mis-detects change to null_resource 'archive'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-notify-slack.