[bug] CloudWatch log group gets created twice and throws an error about terraform-aws-notify-slack HOT 8 CLOSED

I will take a look at this later today or tomorrow.

from terraform-aws-notify-slack.

I am looking into this issue now and the solution proposed in #98 is too simple and does not work for several situations.

I propose to have the following:

1. Users of Terraform 0.12 with AWS Provider 3 to use this module v3.4.0.
2. Users of Terraform 0.13 can use the latest version of this module where Lambda module is the most up-to-date, and depends_on which became available in Terraform 0.13 is used for that.

If there are no objections, I will make a new release now.

from terraform-aws-notify-slack.

@antonbabenko would #98 be an acceptable fix or did you have something else in mind?

Initially, I wanted to delegate the entire CloudWatch log creation to the Lambda module but then I saw your comment so decided to the one in this module instead.

  # Do not use Lambda's policy for cloudwatch logs, because we have to add a policy
  # for KMS conditionally. This way attach_policy_json is always true independenty of
  # the value of presense of KMS. Famous "computed values in count" bug...

from terraform-aws-notify-slack.

same error here

Error: Creating CloudWatch Log Group failed: ResourceAlreadyExistsException: The specified log group already exists:  The CloudWatch Log Group '/aws/lambda/slack_ooh-major' already exists.
  on .terraform/modules/slack_ooh-major.lambda/terraform-aws-lambda-1.18.0/main.tf line 109, in resource "aws_cloudwatch_log_group" "lambda":
 109: resource "aws_cloudwatch_log_group" "lambda" {

which is associate with the below rescources

resource "aws_cloudwatch_log_group" "lambda" {
  count = var.create && var.create_function && ! var.create_layer && ! var.use_existing_cloudwatch_log_group ? 1 : 0

  name              = "/aws/lambda/${var.lambda_at_edge ? "us-east-1." : ""}${var.function_name}"
  retention_in_days = var.cloudwatch_logs_retention_in_days
  kms_key_id        = var.cloudwatch_logs_kms_key_id

  tags = merge(var.tags, var.cloudwatch_logs_tags)
}

i will suggest a variable cloudwatch_log_group which will be default = false
only if create_sns_topic then create a new cloudwatch_log_group with name same sns_topic_name or what they want

from terraform-aws-notify-slack.

There is v4.0.0 - for Terraform 0.13 users, and v3.4.0 - for Terraform 0.12 users.

Please let me know if there are any issues related to this upgrade.

from terraform-aws-notify-slack.

That’s much better @antonbabenko thank you. Wasn’t sure on the approach you usually take for managing multiple TF versions.

from terraform-aws-notify-slack.

thanks @antonbabenko , is working

from terraform-aws-notify-slack.

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-aws-notify-slack.