Giter VIP home page Giter VIP logo

Comments (7)

sethvargo avatar sethvargo commented on June 12, 2024

Hi @chanux - in general, you want to isolate Vault as much as possible from other services. This is also mentioned in the Vault hardening guide. It's not a hard requirement, but Vault should really be on its own dedicated network/IP space and traffic to that network should be restricted behind a firewall.

Let me know if you have other questions.

from terraform-google-vault.

morgante avatar morgante commented on June 12, 2024

@sethvargo I think the enterprise best practice is to use a Shared VPC so Vault can be connected over private space. It can still be restricted by firewall rules for the subnet or service account.

IMO it would make sense to allow this module to accept a custom network input.

from terraform-google-vault.

sethvargo avatar sethvargo commented on June 12, 2024

@morgante wouldn't best practice be to run a dedicated VPC and then use VPC peering instead?

from terraform-google-vault.

sethvargo avatar sethvargo commented on June 12, 2024

FWIW, I'm okay with this change, just trying to figure out what the "default" should be.

from terraform-google-vault.

morgante avatar morgante commented on June 12, 2024

@sethvargo VPC peering has a number of limitations which make it unsuitable in certain environments. I think a dedicated service account (with locked down firewall rules) in a shared VPC is an acceptable tradeoff.

from terraform-google-vault.

Andor avatar Andor commented on June 12, 2024

I think the default should be the current implementation with completely separated VPC and networks. But it would be OK if someone really really wants to be able to put all the eggs into one basket.

from terraform-google-vault.

onetwopunch avatar onetwopunch commented on June 12, 2024

I'll go ahead and get a PR up for this. We also need outputs of the subnet/network as well in case someone does want to put a bastion or firewall rule on that network after Vault is created.

from terraform-google-vault.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.