Panics when emitting issues on child blocks about tflint HOT 2 CLOSED

Two general approaches would be:

1. Add an argument to the issues API that allows the rule to instruct on whether or not the range at issue is an expression or a declaration. This is likely to be a breaking change given that callers use EmitIssue to create issues and pass a Range as its own argument.
2. Ignore reference parsing errors entirely:

   tflint/tflint/runner.go

   Lines 324 to 327 in 5ed807d

   	if diags.HasErrors() {
   	// Maybe this is bug
   	panic(diags)
   	}

On further thought it seems like 2 is actually ok given that this is meant to limit errors to expressions that reference module variables. If the expression is invalid it can't contain any variables.

from tflint.

Agreed with 2. 1 is a better approach, but I think module call inspection should stop assuming only issues for expressions in the first place.

In the future it would be good to redesign the plugin API by terraform-linters/tflint-plugin-sdk#193.

from tflint.