Giter VIP home page Giter VIP logo

Comments (3)

apupier avatar apupier commented on July 30, 2024

for reference, issue discovered while working on https://issues.jboss.org/browse/FUSETOOLS-2183

from m2eclipse-tycho.

apupier avatar apupier commented on July 30, 2024

@fbricon can you have a look please?

from m2eclipse-tycho.

apupier avatar apupier commented on July 30, 2024

seems my first was not right. It was fixing the issue "sometimes" only.

What I observed today for the project attached in https://issues.jboss.org/browse/FUSETOOLS-2183 :

  • the MANIFEST.MF is first generated
  • then the JavaBuilder is cleaning some folders, including target/classes/META-INF
    see org.eclipse.jdt.internal.core.builder.BatchImageBuilder.cleanOutputFolders(boolean)

I'm able to workaround it by adding a check if the target/classes/META-INF/MANIFEST.MF exists when calculating the "generate" boolean:

m2eclipse-tycho/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/felix/internal/MavenBundlePluginConfigurator.java

Lines 108 to 118 in 08cafef

boolean generate = IncrementalProjectBuilder.FULL_BUILD == kind;
// the property is set by OsgiBundleProjectConfigurator.mavenProjectChanged is a workaround for
// m2e design limitation, which does not allow project configurators trigger resource deltas
// visible to build participants. See comment in OsgiBundleProjectConfigurator.mavenProjectChanged
generate =
generate || Boolean.parseBoolean( (String) project.getSessionProperty( PROP_FORCE_GENERATE ) );
// reset FORCE flag so we don't regenerate forever
project.setSessionProperty( PROP_FORCE_GENERATE, null );
generate = generate || isIncludeBndFileChange( buildContext, instructions );

I'm not able to reproduce the issue with a simple project, neither programmatically.

from m2eclipse-tycho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.