Giter VIP home page Giter VIP logo

Comments (8)

LelandSindt avatar LelandSindt commented on June 20, 2024 2

I would like to make sure I understand the intent here. The idea is to group similar topics into a single topic with a json payload.

for example

/teslamate/cars/1/latitude = 1234

and

/teslamate/cars/1/longitude = 1234

would be made available as

/teslamate/cars/1/location = {"latitude":123,"longitude":1234}

but not to group all topics into a single json payload...

/teslamate/cars/1 = { <all of the keys and values....> }

While I can see the value in grouping lat and long into location as they will be consumed together... grouping too many topics together negates the flexibility and scalability that MQTT provides by design.

from teslamate.

longzheng avatar longzheng commented on June 20, 2024 2

Also in regards to the other discussion #3657 It would be nice to have the distance and minutes to destination into MQTT so that I could automate things for my Home Assistant instance.

That's already merged and will be included in the next release.

Just confirming that my PR did not include distance and minutes in the MQTT output, I only added it to the state parser

from teslamate.

LelandSindt avatar LelandSindt commented on June 20, 2024 1

Tagging @tobiasehlert and @brchri as their projects consume Teslamate MQTT payloads.

from teslamate.

WesSec avatar WesSec commented on June 20, 2024

Continued discussion from #3657, focussed on active drive navigation data:

I fully agree, for "same time define data" such as latlong and initial navigation state. For the other travel ETA's not so much, these update throughout the journey, which will require to update the complete blob. It is likely that the latlong will be set (data will be pushed/updated) and the route will still be calculating, resulting in two messages anyway, not solving the issue. This can be tested

Also adding more stuff to a big json requires the processing client (often HA) to parse this json, where normally an mqtt topic can be read easily.

I think both ways can be done and advocated for, zigbee2mqtt is more json based too, but i'd suggest to not wait for a possible complete revamp of the mqtt structure for this awesome change already.

from teslamate.

vincep5 avatar vincep5 commented on June 20, 2024

Also in regards to the other discussion #3657 It would be nice to have the distance and minutes to destination into MQTT so that I could automate things for my Home Assistant instance.

from teslamate.

JakobLichterfeld avatar JakobLichterfeld commented on June 20, 2024

Also in regards to the other discussion #3657 It would be nice to have the distance and minutes to destination into MQTT so that I could automate things for my Home Assistant instance.

That's already merged and will be included in the next release.

from teslamate.

JakobLichterfeld avatar JakobLichterfeld commented on June 20, 2024

Correct, the idea is to bundle the data which belongs together, like position data in one Json blob, time and distance to destination.

from teslamate.

JakobLichterfeld avatar JakobLichterfeld commented on June 20, 2024

Just confirming that my PR did not include distance and minutes in the MQTT output, I only added it to the state parser

Thanks for clarification, absolutely right.

from teslamate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.