Giter VIP home page Giter VIP logo

Comments (13)

candidtim avatar candidtim commented on May 27, 2024

I agree this is annoying. And not only - also you don't know if this is a sign of something not working as expected, or only a "visual thing".

If it will maybe help, versions I've tried are:
test-kitchen: 1.2.1
docker: 1.2.0 and 1.3.1 (reproduced on both)
kitchen-docker: tried 1.2.0, 1.4.0 and 1.5.0 with same result

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

Last time I looked at the source code it was because the docker cli check
was not redirecting the error stream to /dev/null. But it seems that was
addressed in 7ec411e, maybe the fix hasn't made it to the gem repo?

On 12 Nov 2014 13:14, "candidtim" [email protected] wrote:

I agree this is annoying. And not only - also you don't know if this is a
sign of something not working as expected, or only a "visual thing".

If it will maybe help, my versions are:
test-kitchen: 1.2.1
docker: 1.2.0 and 1.3.1 (reproduced on both)
kitchen-docker: tried 1.2.0, 1.4.0 and 1.5.0 with same result


Reply to this email directly or view it on GitHub
#90 (comment)
.

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

I just checked the source from 1.5.0 which gets pulled down from the rubygems site, the change I mentioned is not included.

As there are lots of changes since 1.5.0 was release (July) I'd say it is time for portertech release an update.

Otherwise, do what I have and fork a version of the cookbook and apply the commit yourself. And while you are at it, the one that lets you use DOCKER_HOST env variable too :)

from kitchen-docker.

grubernaut avatar grubernaut commented on May 27, 2024

@peterabbott I can confirmed before that 7ec411e is the fix that addresses this issue for OSX. :)

from kitchen-docker.

iroller avatar iroller commented on May 27, 2024

+1 getting the same problem here

from kitchen-docker.

alambike avatar alambike commented on May 27, 2024

👍

@portertech Driver is great but there is some PRs without merging that could help to improve it .

Could be possible to merge them and update gem version? If you need some help to maintain I'll be happy to assist.

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

It seems that @portertech has all but given up on the project. There have been many requests to merge PRs and release new versions, to no avail. He is still active, committing to other projects, just not this one.

Would be great if we could get more responsiveness and avoid having to maintain our own branches.

Maybe we can band together and create a new driver, in a io.js/node.js kind of way :)

from kitchen-docker.

logankoester avatar logankoester commented on May 27, 2024

@portertech It may seem a small thing, but your work on kitchen-docker has improved my life. If you need to move on to other commitments, don't feel bad about that! We're all happy to pick up where you left off. But if that's indeed the case, would you consider adding @peterabbott or myself as gem maintainers so that we can continue to publish new releases?

@peterabbott Regardless of whether we hear from @portertech, let's pick up the slack. I see that you already have a fork going. How would you feel about reviewing those other pull requests that you mentioned and merging the good ones in with yours?

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

Sounds like a plan. I have been merging some of the PRs as I go. I haven't done the one from the other day yet, the one that added --link capabilities. I'll merge that with any others I haven't (which should be) and then tag a new version.

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

@logankoester sorry bit a bit slow at setting this up, been busy last week at work. Setting something up now. Will add you as a collaborator as well.

from kitchen-docker.

peterabbott avatar peterabbott commented on May 27, 2024

So I have now created a new tagged version that consists of the following PR's

  • PR-71: Use the ENV['DOCKER_HOST']
  • PR-80: Add cpuset option to kitchen docker
  • PR-91: Remove ssh tcp check
  • PR-92: Support --name and --link and -P options to link between some containers.

The others were all duplicates. I am not sure about PR-93, happy to add if people think it is worth while.

https://github.com/peterabbott/kitchen-docker

I updated the README, but to target the version then add the following in your Gemfile

gem 'kitchen-docker', :git => 'https://github.com/peterabbott/kitchen-docker.git', :tag => '1.6.1'

from kitchen-docker.

logankoester avatar logankoester commented on May 27, 2024

Nice work! I don't have a need for #93 personally, but I don't see anything wrong with merging it. @peterabbott

from kitchen-docker.

portertech avatar portertech commented on May 27, 2024

master now redirecting both stderr and stdout to /dev/null.

from kitchen-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.