Giter VIP home page Giter VIP logo

Comments (7)

thomaseizinger avatar thomaseizinger commented on May 31, 2024

A problem with solution 1 is that in order for it to make sense, it have to be implemented on the Image trait like this:

pub trait Image
where
    Self: Sized + Default,
    Self::Args: IntoIterator<Item = String>,
{
    type Args;

    fn start(self) -> Container<DockerCli, Self> {
        let docker = DockerCli::new();

        docker.run(self)
    }

    ...
}
  1. This forces the usage of a specific Docker client (not nice but would be ok)
  2. In order to use methods from a trait, the trait needs to be in scope. Here we are back again with a necessary import from testcontainers.

from testcontainers-rs.

LLFourn avatar LLFourn commented on May 31, 2024

I might be thick but I don't really get the issue. Can't the image crate just compile with whatever testcontainers version you're using assuming the minor versions are the same?

from testcontainers-rs.

thomaseizinger avatar thomaseizinger commented on May 31, 2024

It needs to be the exact same version actually: Cargo needs to be able to find a match between the semver range of the testcontainers dependency for the image crate as well as the one that the user code depends on which tries to start the image.

If the two don't match, the code will not compile because the stuff you import directly from testcontainers is different from what the image crate gets compiled against.

from testcontainers-rs.

LLFourn avatar LLFourn commented on May 31, 2024

So if we change the dependency on things to something like:

[dependencies]
testcontainers = { path = "../../testcontainers", version = "0.2" }

for the images. And a user uses testcontainers version "0.2.2" then it won't just work? Why would it not compile the image against 0.2.2 then as well?

from testcontainers-rs.

thomaseizinger avatar thomaseizinger commented on May 31, 2024

This one would work. As I said, cargo needs to be able to find a 'match' between the two semver ranges that are specified. 0.2.2 is within the semver range 0.2.x so it should work.

from testcontainers-rs.

D4nte avatar D4nte commented on May 31, 2024

You cannot use path in combination with version

from testcontainers-rs.

thomaseizinger avatar thomaseizinger commented on May 31, 2024

You can, cargo will use the version upon publishing and the path for local development.

from testcontainers-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.