Search in association throws missing FROM-clause entry about textacular HOT 6 OPEN

Now I see it. I must use the name of the table instead of the relation. So it would be:

Place.joins(:address).advanced_search(name: 'moraes', addresses: { route: 'moraes' }).explain

That's a little confusing. Wouldn't the standard be to use the relation name?

from textacular.

This is how it works in normal ActiveRecord where clauses as well:

BlogPost.joins(:user).where(users: { username: 'foobar' })

Even if the relation to users was called something else, like author, its still plural users when querying the users table:

BlogPost.joins(:author).where(users: { username: 'foobar' })

I think it would be more confusing for experienced Rails devs to break consistency with ActiveRecord.

from textacular.

#joins uses the relation name, but #where uses the table name. I can't tell what's the standard anymore. I'd say there's no issue then.

from textacular.

I agree, it would be better to use the relation name, but that means a non-bc change to textacular. Once I got some free time, I will change this and deprecate the use of table name.

from textacular.

My speculation (since I haven't read the AR source) is that '#joins' needs to know the relation to do the join properly (since you can configure the foreign keys and whatnot) but '#where' doesn't need as much information to translate a Ruby hash to a SQL where clause.

from textacular.

🤔 Would better README with example on relation search fix this?

from textacular.