Giter VIP home page Giter VIP logo

Comments (3)

vzhong avatar vzhong commented on July 19, 2024

can you just make this open to all fontawesome icons instead of hardcoding the supported list in your source code? For example, I would put ('envelope', 'mailto:[email protected]') and this would automatically retrieve the fa-envelope icon.

from bulrush.

textbook avatar textbook commented on July 19, 2024

As currently written, though, that would render as:

<li><a href="mailto:[email protected]">
  <span class="icon is-small">
    <i class="fa fa-envelope fa-fw"></i>
  </span>
  <span class="link-text">envelope<!-- probably not ideal --></span>
</a></li>

I could make it a three-tuple (name, link, icon), I suppose, but that would mean introducing a compatibility issue. Perhaps a better idea would be using fa-envelope instead of the current default if the link part of the tuple starts with mailto: and the name isn't otherwise a match; would that meet your needs?

from bulrush.

vzhong avatar vzhong commented on July 19, 2024

yeah you're right.. I ended up doing the three tuple solution. However this is not ideal in general because it breaks convention used by other templates.

from bulrush.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.