Numeral 1 or exclamation mark found instead of vertical line | at the end of a verse about bible-punjabi-pavitr-bible-1945 HOT 9 OPEN

Also in Acts, there are 81 verses ending with an exclamation mark !
This seems inordinately high for a book which is largely narrative.
There are even seven instances of double exclamation marks !!
I imagine that most (if not all) of these too should be replaced by a vertical line |

cf. In the KJV, there are simply no exclamation marks in the book of Acts.

I therefore propose the short-term fix as to replace double !! by double || and single ! by single |
This still leaves the freedom for the global replacement of vertical lines. See below.

from bible-punjabi-pavitr-bible-1945.

In our Punjabi Bible, the book of Acts also has a significant number of verses ending with either the single danda or the double danda.

• There are 21 ending with single danda
• There is 1 ending with double danda

This seems to confirm my conjecture in issue #24

from bible-punjabi-pavitr-bible-1945.

Short-term fix just was implemented in my fork of the repo.

Replaced each exclamation mark by a vertical line in Acts

from bible-punjabi-pavitr-bible-1945.

But see also issue #63 which wasn't apparent to me 3 days ago.

from bible-punjabi-pavitr-bible-1945.

In the concatenated USFM file, there are:

• 30 instances of "!||" (exclamation mark followed by two vertical lines)
• 391 instances of "! ||" (as above but with a space before the vertical lines)
• 899 matches to the regexp " ! [^\\|]" (space, exclamation mark, space followed by other than a vertical line)

from bible-punjabi-pavitr-bible-1945.

Still a long way to go on this issue, friends.

from bible-punjabi-pavitr-bible-1945.

Following the merge of pull request #96 which did improve things significantly, we have:

• No remaining vertical lines anywhere.
• No remaining instances of a verse ending with the numeral 1
• Nahum 1:1 still contains the numeral 1 mid-verse.
• Still 1378 verses ending with an exclamation mark - some of which may be typos for a danda.

It could make sense to open separate issues for the last two items, and then close this issue.
Some discussion is needed beforehand.

from bible-punjabi-pavitr-bible-1945.

Just opened issue #98 to focus on Nahum 1:1

from bible-punjabi-pavitr-bible-1945.

Just made a pull request for a commit that fixes Nahum 1:1

from bible-punjabi-pavitr-bible-1945.