I've noticed that when user submit its search on input, it renders to many times. not

that matter was settled at <a class="issue-link js-issue-link" data-error-text="Failed

Too many calls on search input about angular-heroes HOT 1 CLOSED

Th-Fernandes commented on August 10, 2024

Too many calls on search input

from angular-heroes.

Comments (1)

Th-Fernandes commented on August 10, 2024

that matter was settled at #6

the problem was that on previous tries our team was trying to unsubscribe directly on searchInputValue property on userInputService when as matter of fact we should store the searchInputValue set on ngOnInit method at SearchJobsInputComponent and then unsubscribe from the storaged subscription.

//property that stores search input subscription
  searchInputValueSubscription!: Subscription;

  ngOnInit(): void {
   //Assigns subscription to the property
    this.searchInputValueSubscription =
      this.userSearch.searchInputValue.subscribe((inputValue) => {
        this.searchInputControl.setValue(inputValue);
      });
  }

  ngOnDestroy(): void {
   // unsubscribe from storaged subscription, solving the memory leak problem
    this.searchInputValueSubscription.unsubscribe();
  }