Giter VIP home page Giter VIP logo

Comments (4)

cobarx avatar cobarx commented on June 18, 2024 2

Changing the import to:

import Icon from 'react-native-vector-icons/MaterialIcons';

appears to fix this. Haven't had time to thoroughly test and create a PR.

from react-native-btr.

ThakurBallary avatar ThakurBallary commented on June 18, 2024

Hi @noahehall

This package is built using expo and vector-icons are already available in expo. So, we didn't include react-native-vector-icons as dependency.

As @cobarx mentioned a fix to the issue, I'm closing this thread.

Please feel free to open the issue back if you think this has to be included in the package.

from react-native-btr.

cobarx avatar cobarx commented on June 18, 2024

Hi @ThakurBallary, I think supporting non-Expo projects would be a good idea. I have a UI library that I'm hoping to open source. Currently I'm using react-native-btr for my checkboxes, but other people can't be expected to go in and change the source code for react-native-btr just to use my library.

Can we use some kind of import that works on both Expo & non-Expo? This is the best checkbox implementation I've found and it would be great to bring it to a wider audience.

from react-native-btr.

cobarx avatar cobarx commented on June 18, 2024

@ThakurBallary I tested and if we use the syntax I mentioned, it works fine in Expo as well. Therefore, I don't see any drawbacks to supporting non-Expo projects as well.

I have submitted PR #6 to make this change available to everyone.

from react-native-btr.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.