Giter VIP home page Giter VIP logo

Comments (15)

paulcsmith avatar paulcsmith commented on May 27, 2024 2

Thanks for the ping! I'm working on a PR for this now :)

from web-frameworks.

paulcsmith avatar paulcsmith commented on May 27, 2024 1

I've been sick and on vacation :P So not the best week for getting things done. I did get pretty far though. Hoping to have something soon

from web-frameworks.

waghanza avatar waghanza commented on May 27, 2024 1

ok

@paulcsmith crystal clear

@tbrand I think adding an empty manifest is ok for our purpose, even it's not ideal

from web-frameworks.

kalicki avatar kalicki commented on May 27, 2024

News?

from web-frameworks.

kalicki avatar kalicki commented on May 27, 2024

Hey @paulcsmith, news? We look forward to your help =)

from web-frameworks.

paulcsmith avatar paulcsmith commented on May 27, 2024

@kalicki PR open at #100 :D

from web-frameworks.

paulcsmith avatar paulcsmith commented on May 27, 2024

I haven't done any perf tuning on Lucky so I'm not sure how it will fare, but it is using Crystal so I'm sure it will be at somewhat quick

from web-frameworks.

kalicki avatar kalicki commented on May 27, 2024

With the end result we can abstract the demand for improvements. Good Job! Thanks.

from web-frameworks.

kalicki avatar kalicki commented on May 27, 2024

Open issue? For fix error in json
https://github.com/tbrand/which_is_the_fastest/releases/tag/v1.2.3

from web-frameworks.

paulcsmith avatar paulcsmith commented on May 27, 2024

@tbrand Could you provide some more info on what went wrong when compiling/running Lucky? It's hard to say for sure but I'm guessing something went wrong when building it. Maybe you need to install the Lucky CLI first? https://luckyframework.org/guides/installing/#install-lucky

from web-frameworks.

tbrand avatar tbrand commented on May 27, 2024

Oh I see. will try it.

from web-frameworks.

waghanza avatar waghanza commented on May 27, 2024

Lucky failed to compile

@paulcsmith empty manifest seems to be the root cause

@tbrand I've fixed that #116

from web-frameworks.

paulcsmith avatar paulcsmith commented on May 27, 2024

The empty manifest is part of the problem, but I worry it is not a long-term solution. The bin/setup script for Lucky should install the packages and generate an empty manifest automatically. So I'm guessing something failed while running bin/setup. If the Lucky CLI is not installed then the lucky db commands and the command for generating the assets would fail, meaning there would be no manifest

I think the best solution would be to see if installing the CLI fixes the issue. I suppose adding a blank manifest won't hurt but may not be necessary

from web-frameworks.

waghanza avatar waghanza commented on May 27, 2024

@tbrand Can we close ?

from web-frameworks.

tbrand avatar tbrand commented on May 27, 2024

Yup

from web-frameworks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.